Changeset 176699 in webkit

Timestamp:

Dec 2, 2014 4:39:34 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: CSS Minification breaks some selectors with colons
​https://bugs.webkit.org/show_bug.cgi?id=139206

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-02
Reviewed by Simon Fraser.

Do not remove spaces preceeding colons, as they may change the semantics
of selectors with colon prefixes (e.g. "a :not(b)").

At the same time, we can strip spaces around "!" characters, for example
a space is not required before "!important" priority.

• Scripts/cssmin.py:

(cssminify):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Scripts/cssmin.py (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-12-02  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: CSS Minification breaks some selectors with colons
+        https://bugs.webkit.org/show_bug.cgi?id=139206
+
+        Reviewed by Simon Fraser.
+
+        Do not remove spaces preceeding colons, as they may change the semantics
+        of selectors with colon prefixes (e.g. "a :not(b)").
+
+        At the same time, we can strip spaces around "!" characters, for example
+        a space is not required before "!important" priority.
+
+        * Scripts/cssmin.py:
+        (cssminify):
+
 2014-12-01  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebInspectorUI/Scripts/cssmin.py

@@ -31 +31 @@
         (r"\n", ""),                   # delete new lines
         (r"\s+", " "),                 # change multiple spaces to one space
-        (r"\s?([;:{},~>])\s?", r"\1"), # delete space where it is not needed
+        (r"\s?([;{},~>!])\s?", r"\1"), # delete space where it is not needed
+        (r":\s", ":"),                 # delete spaces after colons, but not before. E.g. do not break selectors "a :focus", "b :matches(...)", "c :not(...)" where the leading space is significant
         (r"\s?([-+])(?:\s(?![0-9(]))", r"\1"), # delete whitespace around + and - when not followed by a number or paren. E.g. strip for selector "a + b" but not "calc(a + b)" which requires spaces.
         (r";}", "}")                   # change ';}' to '}' because the semicolon is not needed