Changeset 177258 in webkit

Timestamp:

Dec 13, 2014 10:44:28 PM (9 years ago)

Author:

Alan Bujtas

Message:

​https://bugs.webkit.org/show_bug.cgi?id=139597
rdar://problem/19237334
Fixed positioned pseudo content does not get composited.

Reviewed by Simon Fraser.

This patch ensures that adjustRenderStyle() can access to settings even when Element* is null.

Source/WebCore:

Test: compositing/fixed-positioned-pseudo-content-no-compositing.html

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

LayoutTests:

• compositing/fixed-positioned-pseudo-content-no-compositing-expected.txt: Added.
• compositing/fixed-positioned-pseudo-content-no-compositing.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/fixed-positioned-pseudo-content-no-compositing-expected.txt (added)
• LayoutTests/compositing/fixed-positioned-pseudo-content-no-compositing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/StyleResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-12-13  Zalan Bujtas  <zalan@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=139597
+        rdar://problem/19237334
+        Fixed positioned pseudo content does not get composited.
+
+        Reviewed by Simon Fraser.
+
+        This patch ensures that adjustRenderStyle() can access to settings even when Element* is null. 
+
+        * compositing/fixed-positioned-pseudo-content-no-compositing-expected.txt: Added.
+        * compositing/fixed-positioned-pseudo-content-no-compositing.html: Added.
+
 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-12-13  Zalan Bujtas  <zalan@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=139597
+        rdar://problem/19237334
+        Fixed positioned pseudo content does not get composited.
+
+        Reviewed by Simon Fraser.
+
+        This patch ensures that adjustRenderStyle() can access to settings even when Element* is null. 
+
+        Test: compositing/fixed-positioned-pseudo-content-no-compositing.html
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::adjustRenderStyle):
+
 2014-12-12  Mark Rowe  <mrowe@apple.com>
 

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -1324 +1324 @@
         || style.hasIsolation()
         || style.position() == StickyPosition
-        || (style.position() == FixedPosition && e && e->document().page() && e->document().page()->settings().fixedPositionCreatesStackingContext())
+        || (style.position() == FixedPosition && documentSettings() && documentSettings()->fixedPositionCreatesStackingContext())
         || style.hasFlowFrom()
         ))