Changeset 177265 in webkit


Ignore:
Timestamp:
Dec 14, 2014 11:02:40 AM (9 years ago)
Author:
Chris Dumez
Message:

fast/images/animated-gif-body-outside-viewport.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=139599

Reviewed by Alexey Proskuryakov.

Update fast/images/animated-gif-body-outside-viewport.html to use
shouldBecomeEqual() instead of a setTimeout() + shouldBe() to fix
the flakiness.

  • fast/images/animated-gif-body-outside-viewport-expected.txt:
  • fast/images/animated-gif-body-outside-viewport.html:
  • platform/mac-wk1/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r177263 r177265  
     12014-12-14  Chris Dumez  <cdumez@apple.com>
     2
     3        fast/images/animated-gif-body-outside-viewport.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=139599
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Update fast/images/animated-gif-body-outside-viewport.html to use
     9        shouldBecomeEqual() instead of a setTimeout() + shouldBe() to fix
     10        the flakiness.
     11
     12        * fast/images/animated-gif-body-outside-viewport-expected.txt:
     13        * fast/images/animated-gif-body-outside-viewport.html:
     14        * platform/mac-wk1/TestExpectations:
     15
    1162014-12-14  Ryosuke Niwa  <rniwa@webkit.org>
    217

  • trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport-expected.txt

    r177135 r177265  
    44
    55
    6 PASS isBackgroundAnimated is false
     6PASS isBackgroundAnimated() became false
    77Scroll down so that the body becomes visible.
    8 PASS isBackgroundAnimated is true
     8PASS isBackgroundAnimated() became true
    99PASS successfullyParsed is true
    1010

  • trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport.html

    r177135 r177265  
    66<body style="background-image: url('resources/animated.gif'); background-repeat: repeat; position: relative; left: 0px; top: 700px; width: 200px; height: 200px" onload="runTest()">
    77<script>
     8description("Make sure the background image of a body element that is outside the viewport is not animated");
    89jsTestIsAsync = true;
    910
    10 function checkBackgroundAnimated() {
    11   isBackgroundAnimated = !internals.hasPausedImageAnimations(document.body);
    12   shouldBeTrue("isBackgroundAnimated");
    13   finishJSTest();
     11function isBackgroundAnimated()
     12{
     13  return !internals.hasPausedImageAnimations(document.body);
    1414}
    1515
    16 function checkBackgroundNotAnimated() {
    17   isBackgroundAnimated = !internals.hasPausedImageAnimations(document.body);
    18   description("Make sure the background image of a body element that is outside the viewport is not animated");
    19   shouldBeFalse("isBackgroundAnimated");
    20 
     16function scrollDown() {
    2117  debug("Scroll down so that the body becomes visible.");
    2218  window.scrollBy(0, 600);
    23   setTimeout(checkBackgroundAnimated, 0);
     19  shouldBecomeEqual("isBackgroundAnimated()", "true", finishJSTest);
    2420}
    2521
    2622function imageLoaded() {
    27   setTimeout(checkBackgroundNotAnimated, 200);
     23  shouldBecomeEqual("isBackgroundAnimated()", "false", scrollDown);
    2824}
    2925

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r177239 r177265  
    2828
    2929webkit.org/b/112533 media/auto-play-in-sandbox-with-allow-scripts.html [ Pass Timeout ]
    30 
    31 webkit.org/b/139599 fast/images/animated-gif-body-outside-viewport.html [ Pass Failure ]
    3230
    3331### END OF (1) Failures with bug reports
Note: See TracChangeset for help on using the changeset viewer.