Changeset 178115 in webkit

Timestamp:

Jan 8, 2015, 8:47:53 AM (11 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r177637) [HarfBuzz][GTK][EFL] It made 3 performance tests crash and +24 layout tests crashes/failures
​https://bugs.webkit.org/show_bug.cgi?id=139905

Reviewed by Antti Koivisto.

Source/WebCore:

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): Fallback to
primary font data for missing glyphs.

LayoutTests:

• platform/gtk/TestExpectations: Remove crashing/failing tests

that should pass now.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-01-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r177637) [HarfBuzz][GTK][EFL] It made 3 performance tests crash and +24 layout tests crashes/failures
+        https://bugs.webkit.org/show_bug.cgi?id=139905
+
+        Reviewed by Antti Koivisto.
+
+        * platform/gtk/TestExpectations: Remove crashing/failing tests
+        that should pass now.
+
 2015-01-08  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -619 +619 @@
 
 webkit.org/b/139364 inspector-protocol/debugger/setBreakpoint-dfg.html [ Crash ]
-
-webkit.org/b/139905 css3/flexbox/inline-flex-crash.html [ Crash ]
-webkit.org/b/139905 editing/deleting/regional-indicators.html [ Crash ]
-webkit.org/b/139905 editing/text-iterator/rtl-first-letter-text-iterator-crash.html [ Crash ]
-webkit.org/b/139905 fast/css/line-height-determined-by-primary-font.html [ Failure ]
-webkit.org/b/139905 fast/lists/w3-css3-list-styles-numeric.html [ Crash ]
-webkit.org/b/139905 fast/ruby/bopomofo.html [ Failure ]
-webkit.org/b/139905 fast/ruby/bopomofo-letter-spacing.html [ Failure ]
-webkit.org/b/139905 fast/ruby/bopomofo-rl.html [ Failure ]
-webkit.org/b/139905 fast/text/decorations-with-text-combine.html [ Failure ]
-webkit.org/b/139905 fast/text/emphasis-combined-text.html [ Failure ]
-webkit.org/b/139905 fast/text/emphasis-vertical.html [ Failure ]
-webkit.org/b/139905 fast/text/international/khmer-selection.html [ Crash ]
-webkit.org/b/139905 fast/text/international/plane2.html [ Failure Crash ]
-webkit.org/b/139905 fast/text/justify-ideograph-complex.html [ Crash ]
-webkit.org/b/139905 fast/text/justify-ideograph-simple.html [ Failure Crash ]
-webkit.org/b/139905 fast/text/justify-ideograph-vertical.html [ Failure Crash ]
-webkit.org/b/139905 fast/text/khmer-crash.html [ Crash ]
-webkit.org/b/139905 fast/text/khmer-lao-font.html [ Crash ]
-webkit.org/b/139905 fast/text/midword-break-before-surrogate-pair-2.html [ Crash ]
-webkit.org/b/139905 fast/text/regional-indicator-symobls.html [ Crash ]
-webkit.org/b/139905 fast/text/unicode-variation-selector.html [ Crash ]
-webkit.org/b/139905 fast/url/idna2003.html [ Crash ]
-webkit.org/b/139905 js/kde/parse.html [ Crash ]
-webkit.org/b/139905 svg/custom/svg-fonts-fallback.xhtml [ Crash ]
 
 #////////////////////////////////////////////////////////////////////////////////////////

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-01-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r177637) [HarfBuzz][GTK][EFL] It made 3 performance tests crash and +24 layout tests crashes/failures
+        https://bugs.webkit.org/show_bug.cgi?id=139905
+
+        Reviewed by Antti Koivisto.
+
+        * platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
+        (WebCore::HarfBuzzShaper::collectHarfBuzzRuns): Fallback to
+        primary font data for missing glyphs.
+
 2015-01-08  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

@@ -411 +411 @@
         const UChar* currentCharacterPosition = iterator.characters();
         const SimpleFontData* currentFontData = nextFontData;
+        if (!currentFontData)
+            currentFontData = &m_font->primaryFontData();
         UScriptCode currentScript = nextScript;