Changeset 17848 in webkit

Timestamp:

Nov 18, 2006 2:59:50 PM (17 years ago)

Author:

rwlbuis

Message:

LayoutTests:

Reviewed by Maciej.

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

• fast/css/target-fragment-match-expected.checksum: Added.
• fast/css/target-fragment-match-expected.png: Added.
• fast/css/target-fragment-match-expected.txt: Added.
• fast/css/target-fragment-match.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

Make sure the page does a style recalculation and possible rendering
when navigating back from a page with an anchor to a page without
an anchor.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/target-fragment-match-expected.checksum (added)
• LayoutTests/fast/css/target-fragment-match-expected.png (added)
• LayoutTests/fast/css/target-fragment-match-expected.txt (added)
• LayoutTests/fast/css/target-fragment-match.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/loader/FrameLoader.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2006-11-18  Rob Buis  <buis@kde.org>
+
+        Reviewed by Maciej.
+
+        Testcase for:
+        http://bugs.webkit.org/show_bug.cgi?id=11321
+        Element with :target pseudo-class still matched after fragment identifier change
+
+        * fast/css/target-fragment-match-expected.checksum: Added.
+        * fast/css/target-fragment-match-expected.png: Added.
+        * fast/css/target-fragment-match-expected.txt: Added.
+        * fast/css/target-fragment-match.html: Added.
+
 2006-11-18  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-11-18  Rob Buis  <buis@kde.org>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11321
+        Element with :target pseudo-class still matched after fragment identifier change
+
+        Make sure the page does a style recalculation and possible rendering
+        when navigating back from a page with an anchor to a page without
+        an anchor.
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::gotoAnchor):
+
 2006-11-18  Don Gibson  <dgibson77@gmail.com>
 

trunk/WebCore/loader/FrameLoader.cpp

@@ -995 +995 @@
 {
     // If our URL has no ref, then we have no place we need to jump to.
-    if (!m_URL.hasRef())
+    // OTOH if css target was set previously, we want to set it to 0, recalc
+    // and possibly repaint because :target pseudo class may have been
+    // set(See bug 11321)
+    if (!m_URL.hasRef() &&
+        !(m_frame->document() && m_frame->document()->getCSSTarget()))
         return;