Changeset 179408 in webkit
- Timestamp:
- Jan 30, 2015 12:46:00 PM (9 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WTF/ChangeLog
r179354 r179408 1 2015-01-30 Antti Koivisto <antti@apple.com> 2 3 OSObjectPtr does not work with dispatch_data_t on Maverics 4 https://bugs.webkit.org/show_bug.cgi?id=141081 5 6 Reviewed by Pratik Solanki. 7 8 Trying to use OSObjectPtr<dispatch_data_t> throws 9 10 -[OS_dispatch_data _xref_dispose]: unrecognized selector sent to instance 0 11 12 * wtf/OSObjectPtr.h: 13 (WTF::retainOSObject<dispatch_data_t>): 14 (WTF::releaseOSObject<dispatch_data_t>): 15 16 Add specialization for dispatch_data_t on Maverics. 17 1 18 2015-01-29 Santosh Mahto <santoshbit2007@gmail.com> 2 19 -
trunk/Source/WTF/wtf/OSObjectPtr.h
r177523 r179408 33 33 #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101000 34 34 35 #include <dispatch/dispatch.h> 35 36 #if __has_include(<os/object_private.h>) 36 37 #include <os/object_private.h> … … 82 83 #endif 83 84 } 85 86 #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101000 87 template<> inline void retainOSObject<dispatch_data_t>(dispatch_data_t ptr) 88 { 89 dispatch_retain(ptr); 90 } 91 92 template<> inline void releaseOSObject<dispatch_data_t>(dispatch_data_t ptr) 93 { 94 dispatch_release(ptr); 95 } 96 #endif 84 97 85 98 template<typename T> class OSObjectPtr { -
trunk/Tools/ChangeLog
r179405 r179408 1 2015-01-30 Antti Koivisto <antti@apple.com> 2 3 OSObjectPtr does not work with dispatch_data_t on Maverics 4 https://bugs.webkit.org/show_bug.cgi?id=141081 5 6 Reviewed by Pratik Solanki. 7 8 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: 9 (TestWebKitAPI::TEST): 10 1 11 2015-01-30 Brent Fulgham <bfulgham@apple.com> 2 12 -
trunk/Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp
r174809 r179408 64 64 } 65 65 66 TEST(OSObjectPtr, DispatchData) 67 { 68 uint8_t buffer[1024] { }; 69 OSObjectPtr<dispatch_data_t> foo = adoptOSObject(dispatch_data_create(buffer, 1024, nullptr, DISPATCH_DATA_DESTRUCTOR_DEFAULT)); 70 EXPECT_EQ(1, CFGetRetainCount(foo.get())); 71 { 72 OSObjectPtr<dispatch_data_t> foo2 = foo; 73 EXPECT_EQ(2, CFGetRetainCount(foo.get())); 74 } 75 EXPECT_EQ(1, CFGetRetainCount(foo.get())); 76 } 77 66 78 } // namespace TestWebKitAPI
Note: See TracChangeset
for help on using the changeset viewer.