Changeset 179699 in webkit


Ignore:
Timestamp:
Feb 5, 2015 11:37:11 AM (9 years ago)
Author:
jer.noble@apple.com
Message:

[Mac] HLS <video> will not fire 'progress' events, only 'stalled'.
​https://bugs.webkit.org/show_bug.cgi?id=141284

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/media/hls/hls-progress.html

totalBytes() will always return 0 for HLS streams, which will cause didLoadingProgress() to always
return false. Skip this optimization.

Drive-by fix: duration() will always return 0 for this class as well. Use durationMediaTime() instead.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress):

LayoutTests:

  • http/tests/media/hls/hls-progress-expected.txt: Added.
  • http/tests/media/hls/hls-progress.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r179697 r179699  
     12015-02-05  Jer Noble  <jer.noble@apple.com>
     2
     3        [Mac] HLS <video> will not fire 'progress' events, only 'stalled'.
     4        https://bugs.webkit.org/show_bug.cgi?id=141284
     5
     6        Reviewed by Brent Fulgham.
     7
     8        * http/tests/media/hls/hls-progress-expected.txt: Added.
     9        * http/tests/media/hls/hls-progress.html: Added.
     10
    1112015-02-05  Zalan Bujtas  <zalan@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r179695 r179699  
     12015-02-05  Jer Noble  <jer.noble@apple.com>
     2
     3        [Mac] HLS <video> will not fire 'progress' events, only 'stalled'.
     4        https://bugs.webkit.org/show_bug.cgi?id=141284
     5
     6        Reviewed by Brent Fulgham.
     7
     8        Test: http/tests/media/hls/hls-progress.html
     9
     10        totalBytes() will always return 0 for HLS streams, which will cause didLoadingProgress() to always
     11        return false. Skip this optimization.
     12
     13        Drive-by fix: duration() will always return 0 for this class as well. Use durationMediaTime() instead.
     14
     15        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
     16        (WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress):
     17
    1182015-02-05  Darin Adler  <darin@apple.com>
    219

  • trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp

    r179220 r179699  
    431431bool MediaPlayerPrivateAVFoundation::didLoadingProgress() const
    432432{
    433     if (!duration() || !totalBytes())
     433    if (!durationMediaTime())
    434434        return false;
    435435    MediaTime currentMaxTimeLoaded = maxTimeLoaded();
Note: See TracChangeset for help on using the changeset viewer.