Changeset 179817 in webkit

Timestamp:

Feb 8, 2015 6:42:22 PM (9 years ago)

Author:

benjamin@webkit.org

Message:

Remove a few duplicate propagation steps from the DFG's PredictionPropagation phase
​https://bugs.webkit.org/show_bug.cgi?id=141363

Reviewed by Darin Adler.

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
Some blocks were duplicated, they probably evolved separately
to the same state.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGPredictionPropagationPhase.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-02-08  Benjamin Poulain  <benjamin@webkit.org>
+
+        Remove a few duplicate propagation steps from the DFG's PredictionPropagation phase
+        https://bugs.webkit.org/show_bug.cgi?id=141363
+
+        Reviewed by Darin Adler.
+
+        * dfg/DFGPredictionPropagationPhase.cpp:
+        (JSC::DFG::PredictionPropagationPhase::propagate):
+        Some blocks were duplicated, they probably evolved separately
+        to the same state.
+
 2015-02-08  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp

@@ -250 +250 @@
             break;
         }
-            
-        case ArithAdd: {
-            SpeculatedType left = node->child1()->prediction();
-            SpeculatedType right = node->child2()->prediction();
-            
-            if (left && right) {
-                if (m_graph.addSpeculationMode(node, m_pass) != DontSpeculateInt32)
-                    changed |= mergePrediction(SpecInt32);
-                else if (m_graph.addShouldSpeculateMachineInt(node))
-                    changed |= mergePrediction(SpecInt52);
-                else
-                    changed |= mergePrediction(speculatedDoubleTypeForPredictions(left, right));
-            }
-            break;
-        }
-            
+
+        case ArithAdd:
         case ArithSub: {
             SpeculatedType left = node->child1()->prediction();
@@ -321 +307 @@
             break;
         }
-            
-        case ArithDiv: {
-            SpeculatedType left = node->child1()->prediction();
-            SpeculatedType right = node->child2()->prediction();
-            
-            if (left && right) {
-                if (Node::shouldSpeculateInt32OrBooleanForArithmetic(node->child1().node(), node->child2().node())
-                    && node->canSpeculateInt32(m_pass))
-                    changed |= mergePrediction(SpecInt32);
-                else
-                    changed |= mergePrediction(SpecBytecodeDouble);
-            }
-            break;
-        }
-            
+
+        case ArithDiv:
         case ArithMod: {
             SpeculatedType left = node->child1()->prediction();
@@ -596 +569 @@
             break;
         }
-        case HasGenericProperty: {
-            changed |= setPrediction(SpecBoolean);
-            break;
-        }
-        case HasStructureProperty: {
-            changed |= setPrediction(SpecBoolean);
-            break;
-        }
+        case HasGenericProperty:
+        case HasStructureProperty:
         case HasIndexedProperty: {
             changed |= setPrediction(SpecBoolean);
             break;
         }
-        case GetStructurePropertyEnumerator: {
-            changed |= setPrediction(SpecCell);
-            break;
-        }
+        case GetStructurePropertyEnumerator:
         case GetGenericPropertyEnumerator: {
             changed |= setPrediction(SpecCell);