Changeset 179841 in webkit

Timestamp:

Feb 9, 2015 12:27:51 PM (9 years ago)

Author:

Brent Fulgham

Message:

AX: [Win] OBJID_CLIENT comparisons broken in 64-bit builds
​https://bugs.webkit.org/show_bug.cgi?id=141391
<rdar://problem/19767342>

Reviewed by Anders Carlsson.

• WebView.cpp:

(WebView::onGetObject): Cast lParam as LONG to ensure proper word size for
comparison against OBJID_CLIENT.

Location:

trunk/Source/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebView.cpp (modified) (1 diff)

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2015-02-09  Brent Fulgham  <bfulgham@apple.com>
+
+        AX: [Win] OBJID_CLIENT comparisons broken in 64-bit builds
+        https://bugs.webkit.org/show_bug.cgi?id=141391
+        <rdar://problem/19767342>
+
+        Reviewed by Anders Carlsson.
+
+        * WebView.cpp:
+        (WebView::onGetObject): Cast lParam as LONG to ensure proper word size for
+        comparison against OBJID_CLIENT.
+
 2015-02-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/win/WebView.cpp

@@ -6283 +6283 @@
     lResult = 0;
 
-    if (lParam != OBJID_CLIENT)
+    if (static_cast<LONG>(lParam) != OBJID_CLIENT)
         return false;