Changeset 179860 in webkit

Timestamp:

Feb 9, 2015 5:17:44 PM (9 years ago)

Author:

Chris Dumez

Message:

Check for self-assignment in Length::operator=(const Length&)
​https://bugs.webkit.org/show_bug.cgi?id=141402

Reviewed by Andreas Kling.

Check for self-assignment in Length::operator=(const Length&) as
calling memcpy() with the same source and destination addresses has
undefined behavior.

• platform/Length.h:

(WebCore::Length::operator=):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/Length.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-02-09  Chris Dumez  <cdumez@apple.com>
+
+        Check for self-assignment in Length::operator=(const Length&)
+        https://bugs.webkit.org/show_bug.cgi?id=141402
+
+        Reviewed by Andreas Kling.
+
+        Check for self-assignment in Length::operator=(const Length&) as
+        calling memcpy() with the same source and destination addresses has
+        undefined behavior.
+
+        * platform/Length.h:
+        (WebCore::Length::operator=):
+
 2015-02-09  Roger Fong  <roger_fong@apple.com>
 

trunk/Source/WebCore/platform/Length.h

@@ -180 +180 @@
 inline Length& Length::operator=(const Length& other)
 {
+    if (this == &other)
+        return *this;
+
     if (other.isCalculated())
         other.ref();