Changeset 179896 in webkit


Ignore:
Timestamp:
Feb 10, 2015 4:00:53 PM (9 years ago)
Author:
achristensen@apple.com
Message:

Stop using WebCore.exp.in on Mac and iOS.
​https://bugs.webkit.org/show_bug.cgi?id=141413

Reviewed by Dan Bates.

  • Configurations/Base.xcconfig:

Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.

  • platform/PlatformExportMacros.h:

Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r179895 r179896  
     12015-02-10  Alex Christensen  <achristensen@webkit.org>
     2
     3        Stop using WebCore.exp.in on Mac and iOS.
     4        https://bugs.webkit.org/show_bug.cgi?id=141413
     5
     6        Reviewed by Dan Bates.
     7
     8        * Configurations/Base.xcconfig:
     9        Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.
     10        * platform/PlatformExportMacros.h:
     11        Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).
     12
    1132015-02-10  Chris Dumez  <cdumez@apple.com>
    214
    … …  
    2133        * loader/DocumentLoader.cpp:
    2234        (WebCore::DocumentLoader::detachFromFrame):
     35
     362015-02-10  Alex Christensen  <achristensen@webkit.org>
     37
     38        Stop using WebCore.exp.in on Mac and iOS.
     39        https://bugs.webkit.org/show_bug.cgi?id=141413
     40
     41        Reviewed by Dan Bates.
     42
     43        * Configurations/Base.xcconfig:
     44        Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.
     45        * platform/PlatformExportMacros.h:
     46        Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).
    2347
    24482015-02-10  Alex Christensen  <achristensen@webkit.org>

  • trunk/Source/WebCore/Configurations/Base.xcconfig

    r179450 r179896  
    5757GCC_OBJC_CALL_CXX_CDTORS = YES;
    5858GCC_PRECOMPILE_PREFIX_HEADER = YES;
     59GCC_SYMBOLS_PRIVATE_EXTERN = YES;
    5960GCC_THREADSAFE_STATICS = NO;
    6061GCC_TREAT_WARNINGS_AS_ERRORS = YES;

  • trunk/Source/WebCore/platform/PlatformExportMacros.h

    r172862 r179896  
    3333#include <wtf/ExportMacros.h>
    3434
    35 #if defined(BUILDING_WebCore) || defined(BUILDING_WebKit) || \
    36     defined(STATICALLY_LINKED_WITH_WebCore) || defined(STATICALLY_LINKED_WITH_WebKit)
    37 #define WEBCORE_IS_LINKED_IN_SAME_BINARY 1
    38 #endif
    39 
    4035// See note in wtf/Platform.h for more info on EXPORT_MACROS.
    4136#if USE(EXPORT_MACROS)
    4237
    43 #if defined(WEBCORE_IS_LINKED_IN_SAME_BINARY)
    44 #define WEBKIT_EXPORTDATA WTF_EXPORT
     38// FIXME: Get rid of WebKitExports.def.in and make this work on Windows.
     39#if !PLATFORM(WIN)
     40#define WEBCORE_EXPORT WTF_EXPORT
    4541#else
    46 #define WEBKIT_EXPORTDATA WTF_IMPORT
     42#define WEBCORE_EXPORT
    4743#endif
    48 
    49 // FIXME: This should be WTF_EXPORT once WEBCORE_EXPORT is used instead of WebCore.exp.in.
    50 #define WEBCORE_EXPORT
    5144
    5245#else // !USE(EXPORT_MACROS)
    … …  
    5447#define WEBCORE_EXPORT
    5548
    56 #if OS(WINDOWS) && !COMPILER(GCC)
    57 
    58 #if defined(WEBCORE_IS_LINKED_IN_SAME_BINARY)
    59 #define WEBKIT_EXPORTDATA __declspec(dllexport)
    60 #else
    61 #define WEBKIT_EXPORTDATA __declspec(dllimport)
    62 #endif
    63 
    64 #else // !PLATFORM...
    65 
    66 #define WEBKIT_EXPORTDATA
    67 
    68 #endif // !PLATFORM...
    69 
    7049#endif // USE(EXPORT_MACROS)
    7150
Note: See TracChangeset for help on using the changeset viewer.