Changeset 180113 in webkit

Timestamp:

Feb 14, 2015 12:41:18 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Symbol RemoteObject should not send sub-type
​https://bugs.webkit.org/show_bug.cgi?id=141604

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-14
Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/InjectedScriptSource.js:

LayoutTests:

• inspector/model/remote-object-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/model/remote-object-expected.txt (modified) (2 diffs)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/inspector/InjectedScriptSource.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Symbol RemoteObject should not send sub-type
+        https://bugs.webkit.org/show_bug.cgi?id=141604
+
+        Reviewed by Brian Burg.
+
+        * inspector/model/remote-object-expected.txt:
+
 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
 

trunk/LayoutTests/inspector/model/remote-object-expected.txt

@@ -20 +20 @@
 {
   "_type": "symbol",
-  "_subtype": "symbol",
   "_objectId": "<filtered>",
   "_description": "Symbol()"
@@ -29 +28 @@
 {
   "_type": "symbol",
-  "_subtype": "symbol",
   "_objectId": "<filtered>",
   "_description": "Symbol(test)"

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Symbol RemoteObject should not send sub-type
+        https://bugs.webkit.org/show_bug.cgi?id=141604
+
+        Reviewed by Brian Burg.
+
+        * inspector/InjectedScriptSource.js:
+
 2015-02-13  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js

@@ -655 +655 @@
             return "null";
 
-        if (this.isPrimitiveValue(obj))
+        if (this.isPrimitiveValue(obj) || isSymbol(obj))
             return null;