Changeset 180901 in webkit
- Timestamp:
- Mar 2, 2015 3:39:47 PM (9 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r180900 r180901 1 2015-03-02 Mark Lam <mark.lam@apple.com> 2 3 The InspectorTimelineAgent should gracefully handle attempts to start more than once. 4 <https://webkit.org/b/142189> 5 6 Reviewed by Joseph Pecoraro. 7 8 * TestExpectations: 9 - Unskipped inspector/timeline tests. 10 1 11 2015-03-02 Brent Fulgham <bfulgham@apple.com> 2 12 -
trunk/LayoutTests/TestExpectations
r180887 r180901 98 98 webkit.org/b/137131 inspector/debugger [ Skip ] 99 99 webkit.org/b/137130 inspector/replay [ Skip ] 100 webkit.org/b/137131 inspector/timeline [ Skip ]101 100 inspector/model/remote-object-get-properties.html [ Skip ] 102 101 inspector/model/remote-object-weak-collection.html [ Skip ] -
trunk/Source/WebCore/ChangeLog
r180898 r180901 1 2015-03-02 Mark Lam <mark.lam@apple.com> 2 3 The InspectorTimelineAgent should gracefully handle attempts to start more than once. 4 <https://webkit.org/b/142189> 5 6 Reviewed by Joseph Pecoraro. 7 8 No new tests. Unskipped an existing test that already asserts this. 9 10 InspectorTimelineAgent::internalStop() already checks for redundant calls to it in 11 case the InspectorTimelineAgent is already disabled. Similarly, 12 InspectorTimelineAgent::internalStart() should check if the InspectorTimelineAgent 13 is already enabled before proceeding to do work to enable it. Though wasteful, 14 it is legal for clients of the InspectorTimelineAgent to invoke start on it more 15 than once. Hence, this check is needed. 16 17 This check fixes the debug assertion failure when running the 18 inspector/timeline/debugger-paused-while-recording.html test. The test can now 19 be unskipped. 20 21 * inspector/InspectorTimelineAgent.cpp: 22 (WebCore::InspectorTimelineAgent::internalStart): 23 1 24 2015-03-02 Roger Fong <roger_fong@apple.com> 2 25 -
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
r180116 r180901 106 106 void InspectorTimelineAgent::internalStart(const int* maxCallStackDepth) 107 107 { 108 if (m_enabled) 109 return; 110 108 111 if (maxCallStackDepth && *maxCallStackDepth > 0) 109 112 m_maxCallStackDepth = *maxCallStackDepth;
Note: See TracChangeset
for help on using the changeset viewer.