Changeset 181078 in webkit

Timestamp:

Mar 5, 2015 8:51:26 AM (9 years ago)

Author:

Brent Fulgham

Message:

[Win] AX: Implement support for ARIA 1.1 'switch' role
​https://bugs.webkit.org/show_bug.cgi?id=142016
<rdar://problem/19953264>

Reviewed by Chris Fleizach.

The changes in Bug 141986 did not update the proper Windows routines to
support the new ARIA 1.1 role. This turned out to be trivial.

• AccessibleBase.cpp:

(MSAARole): Provide MSAA role for 'switch'. Also correct 'ToggleButtonRole',
which was improperly reporting as 'push button'.

Location:

trunk/Source/WebKit/win

Files:

• AccessibleBase.cpp (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/win/AccessibleBase.cpp

@@ -849 +849 @@
             return ROLE_SYSTEM_RADIOBUTTON;
         case WebCore::CheckBoxRole:
+        case WebCore::ToggleButtonRole:
+        case WebCore::SwitchRole:
             return ROLE_SYSTEM_CHECKBUTTON;
         case WebCore::SliderRole:
@@ -915 +917 @@
             return ROLE_SYSTEM_SPINBUTTON;
         case WebCore::SpinButtonPartRole:
-            return ROLE_SYSTEM_PUSHBUTTON;
-        case WebCore::ToggleButtonRole:
             return ROLE_SYSTEM_PUSHBUTTON;
         case WebCore::ToolbarRole:

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2015-03-04  Brent Fulgham  <bfulgham@apple.com>
+
+        [Win] AX: Implement support for ARIA 1.1 'switch' role
+        https://bugs.webkit.org/show_bug.cgi?id=142016
+        <rdar://problem/19953264>
+
+        Reviewed by Chris Fleizach.
+
+        The changes in Bug 141986 did not update the proper Windows routines to
+        support the new ARIA 1.1 role. This turned out to be trivial.
+
+        * AccessibleBase.cpp:
+        (MSAARole): Provide MSAA role for 'switch'. Also correct 'ToggleButtonRole',
+        which was improperly reporting as 'push button'.
+
 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>