Changeset 181119 in webkit

Timestamp:

Mar 5, 2015 4:49:53 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Follow-up fixes to ObjectTreeBaseTreeElement
​https://bugs.webkit.org/show_bug.cgi?id=142367

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-05
Reviewed by Timothy Hatcher.

• UserInterface/Views/ObjectTreeMapEntryTreeElement.js:

(WebInspector.ObjectTreeMapEntryTreeElement.prototype.propertyPathType):

• UserInterface/Views/ObjectTreeSetIndexTreeElement.js:

(WebInspector.ObjectTreeSetIndexTreeElement.prototype.resolvedValuePropertyPath):
(WebInspector.ObjectTreeSetIndexTreeElement.prototype._titleFragment):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ObjectTreeMapEntryTreeElement.js (modified) (1 diff)
• UserInterface/Views/ObjectTreeSetIndexTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-03-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Follow-up fixes to ObjectTreeBaseTreeElement
+        https://bugs.webkit.org/show_bug.cgi?id=142367
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
+        (WebInspector.ObjectTreeMapEntryTreeElement.prototype.propertyPathType):
+        * UserInterface/Views/ObjectTreeSetIndexTreeElement.js:
+        (WebInspector.ObjectTreeSetIndexTreeElement.prototype.resolvedValuePropertyPath):
+        (WebInspector.ObjectTreeSetIndexTreeElement.prototype._titleFragment):
+
 2015-03-05  Tobias Reiss  <tobi+webkit@basecode.de>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js

@@ -54 +54 @@
     {
         return this._object;
+    },
+
+    propertyPathType: function()
+    {
+        return WebInspector.PropertyPath.Type.Value;
     },
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js

@@ -55 +55 @@
     },
 
+    resolvedValuePropertyPath: function()
+    {
+        return this.propertyPath.appendSetIndex(this._object);
+    },
+
     // Private
 
@@ -61 +66 @@
         var container = document.createDocumentFragment();
 
-        var propertyPath = this.propertyPath.appendSetIndex(this._object);
+        var propertyPath = this.resolvedValuePropertyPath();
 
         // Set bullet.