Changeset 181137 in webkit

Timestamp:

Mar 5, 2015 9:17:53 PM (9 years ago)

Author:

Brent Fulgham

Message:

[Mac] 'Gliding' phase of scroll snap points is incorrect on desktop
​https://bugs.webkit.org/show_bug.cgi?id=142351
<rdar://problem/20058023>

Reviewed by Dean Jackson.

This problem was caused by incorrectly starting a new snapping animation timer when the
"end momentum" phase event had been received. This caused WebKit to recalculate the
animation curve for the remaining distance, resulting in the bad animation behavior.

Removing this incorrect start animation command when entering the momentum ended state
resolves the problem.

• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Remove the command to
start a new snap animation when entering the "end momentum" state.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/cocoa/ScrollController.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-05  Brent Fulgham  <bfulgham@apple.com>
+
+        [Mac] 'Gliding' phase of scroll snap points is incorrect on desktop
+        https://bugs.webkit.org/show_bug.cgi?id=142351
+        <rdar://problem/20058023>
+
+        Reviewed by Dean Jackson.
+
+        This problem was caused by incorrectly starting a new snapping animation timer when the
+        "end momentum" phase event had been received. This caused WebKit to recalculate the
+        animation curve for the remaining distance, resulting in the bad animation behavior.
+
+        Removing this incorrect start animation command when entering the momentum ended state
+        resolves the problem.
+
+        * platform/cocoa/ScrollController.mm:
+        (WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Remove the command to
+        start a new snap animation when entering the "end momentum" state.
+
 2015-03-05  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WebCore/platform/cocoa/ScrollController.mm

@@ -538 +538 @@
         
     case WheelEventStatus::InertialScrollEnd:
-        beginScrollSnapAnimation(axis, ScrollSnapState::Snapping);
         snapState.clearInitialWheelDeltaWindow();
         snapState.m_shouldOverrideWheelEvent = false;