Changeset 181318 in webkit

Timestamp:

Mar 10, 2015 1:33:30 AM (9 years ago)

Author:

Csaba Osztrogonác

Message:

[cmake] Handle unused parameter warnings as build errors except in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=142338

Reviewed by Gyuyoung Kim.

.:

• Source/cmake/WebKitHelpers.cmake:

Source/WebKit2:

• CMakeLists.txt:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebKit2/CMakeLists.txt (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/cmake/WebKitHelpers.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2015-03-10  Csaba Osztrogonác  <ossy@webkit.org>
+
+        [cmake] Handle unused parameter warnings as build errors except in WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=142338
+
+        Reviewed by Gyuyoung Kim.
+
+        * Source/cmake/WebKitHelpers.cmake:
+
 2015-03-03  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebKit2/CMakeLists.txt

@@ -761 +761 @@
 endmacro()
 
+# Suppress unused parameter warnings for sources in WebKit2.
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-unused-parameter")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-parameter")
+
 WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-03-10  Csaba Osztrogonác  <ossy@webkit.org>
+
+        [cmake] Handle unused parameter warnings as build errors except in WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=142338
+
+        Reviewed by Gyuyoung Kim.
+
+        * CMakeLists.txt:
+
 2015-03-10  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/cmake/WebKitHelpers.cmake

@@ -23 +23 @@
         # Enable errors on warning
         if (OPTION_ENABLE_WERROR)
-            set(OLD_COMPILE_FLAGS "-Werror -Wno-error=unused-parameter ${OLD_COMPILE_FLAGS}")
+            set(OLD_COMPILE_FLAGS "-Werror ${OLD_COMPILE_FLAGS}")
         endif ()