Changeset 181514 in webkit

Timestamp:

Mar 15, 2015 3:47:08 PM (9 years ago)

Author:

Simon Fraser

Message:

Clean up related to wheelEvent names
​https://bugs.webkit.org/show_bug.cgi?id=142713

Reviewed by Anders Carlsson.

Add EventNames::isWheelEventType() and use it in places that test for the
two wheel event names.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):

• dom/Document.h: No need for exports (I grepped). Pass the Node*, which

will be used in a later patch.

• dom/EventNames.h:

(WebCore::EventNames::isWheelEventType):

• dom/Node.cpp:

(WebCore::Node::didMoveToNewDocument):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::defaultEventHandler):

• html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsAppleEventListener::handleEvent):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

• page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToScrollWheelEvents): Remove dead code.

Source/WebKit2:

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Document.cpp (modified) (5 diffs)
• WebCore/dom/Document.h (modified) (2 diffs)
• WebCore/dom/EventNames.h (modified) (2 diffs)
• WebCore/dom/Node.cpp (modified) (5 diffs)
• WebCore/history/CachedFrame.cpp (modified) (1 diff)
• WebCore/html/shadow/MediaControlsApple.cpp (modified) (1 diff)
• WebCore/page/DOMWindow.cpp (modified) (2 diffs)
• WebCore/page/ios/FrameIOS.mm (modified) (2 diffs)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/Plugins/PluginView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Clean up related to wheelEvent names
+        https://bugs.webkit.org/show_bug.cgi?id=142713
+
+        Reviewed by Anders Carlsson.
+
+        Add EventNames::isWheelEventType() and use it in places that test for the
+        two wheel event names.
+
+        * dom/Document.cpp:
+        (WebCore::Document::didAddWheelEventHandler):
+        (WebCore::Document::didRemoveWheelEventHandler):
+        * dom/Document.h: No need for exports (I grepped). Pass the Node*, which
+        will be used in a later patch.
+        * dom/EventNames.h:
+        (WebCore::EventNames::isWheelEventType):
+        * dom/Node.cpp:
+        (WebCore::Node::didMoveToNewDocument):
+        (WebCore::tryAddEventListener):
+        (WebCore::tryRemoveEventListener):
+        (WebCore::Node::defaultEventHandler):
+        * html/shadow/MediaControlsApple.cpp:
+        (WebCore::MediaControlsAppleEventListener::handleEvent):
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::addEventListener):
+        (WebCore::DOMWindow::removeEventListener):
+        * page/ios/FrameIOS.mm:
+        (WebCore::ancestorRespondingToScrollWheelEvents): Remove dead code.
+
 2015-03-15  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -5996 +5996 @@
 }
 
-void Document::didAddWheelEventHandler()
+void Document::didAddWheelEventHandler(Node&)
 {
     ++m_wheelEventHandlerCount;
@@ -6002 +6002 @@
 }
 
-void Document::didRemoveWheelEventHandler()
+void Document::didRemoveWheelEventHandler(Node&)
 {
     ASSERT(m_wheelEventHandlerCount > 0);
@@ -6009 +6009 @@
 }
 
-void Document::didAddTouchEventHandler(Node* handler)
+void Document::didAddTouchEventHandler(Node& handler)
 {
 #if ENABLE(TOUCH_EVENTS)
     if (!m_touchEventTargets.get())
         m_touchEventTargets = std::make_unique<TouchEventTargetSet>();
-    m_touchEventTargets->add(handler);
+    m_touchEventTargets->add(&handler);
     if (Document* parent = parentDocument()) {
         parent->didAddTouchEventHandler(this);
@@ -6028 +6028 @@
 }
 
-void Document::didRemoveTouchEventHandler(Node* handler)
+void Document::didRemoveTouchEventHandler(Node& handler)
 {
 #if ENABLE(TOUCH_EVENTS)
@@ -6034 +6034 @@
         return;
     ASSERT(m_touchEventTargets->contains(handler));
-    m_touchEventTargets->remove(handler);
+    m_touchEventTargets->remove(&handler);
     if (Document* parent = parentDocument()) {
         parent->didRemoveTouchEventHandler(this);

trunk/Source/WebCore/dom/Document.h

@@ -1123 +1123 @@
 
     unsigned wheelEventHandlerCount() const { return m_wheelEventHandlerCount; }
-    WEBCORE_EXPORT void didAddWheelEventHandler();
-    WEBCORE_EXPORT void didRemoveWheelEventHandler();
+    void didAddWheelEventHandler(Node&);
+    void didRemoveWheelEventHandler(Node&);
 
     double lastHandledUserGestureTimestamp() const { return m_lastHandledUserGestureTimestamp; }
@@ -1135 +1135 @@
 #endif
 
-    void didAddTouchEventHandler(Node*);
-    void didRemoveTouchEventHandler(Node*);
+    void didAddTouchEventHandler(Node&);
+    void didRemoveTouchEventHandler(Node&);
 
 #if ENABLE(TOUCH_EVENTS)

trunk/Source/WebCore/dom/EventNames.h

@@ -265 +265 @@
     // FIXME: Inelegant to call these both event names and event types.
     // We should choose one term and stick to it.
+    bool isWheelEventType(const AtomicString& eventType) const;
     bool isGestureEventType(const AtomicString& eventType) const;
     bool isTouchEventType(const AtomicString& eventType) const;
@@ -300 +301 @@
 }
 
+inline bool EventNames::isWheelEventType(const AtomicString& eventType) const
+{
+    return eventType == wheelEvent
+        || eventType == mousewheelEvent;
+}
+
 inline std::array<std::reference_wrapper<const AtomicString>, 4> EventNames::touchEventNames() const
 {

trunk/Source/WebCore/dom/Node.cpp

@@ -1713 +1713 @@
     }
 
-    unsigned numWheelEventHandlers = getEventListeners(eventNames().mousewheelEvent).size()
-        + getEventListeners(eventNames().wheelEvent).size();
+    unsigned numWheelEventHandlers = getEventListeners(eventNames().mousewheelEvent).size() + getEventListeners(eventNames().wheelEvent).size();
     for (unsigned i = 0; i < numWheelEventHandlers; ++i) {
-        oldDocument->didRemoveWheelEventHandler();
-        document().didAddWheelEventHandler();
+        oldDocument->didRemoveWheelEventHandler(*this);
+        document().didAddWheelEventHandler(*this);
     }
 
@@ -1723 +1722 @@
     for (auto& name : eventNames().touchEventNames())
         numTouchEventHandlers += getEventListeners(name).size();
+
     for (unsigned i = 0; i < numTouchEventHandlers; ++i) {
-        oldDocument->didRemoveTouchEventHandler(this);
-        document().didAddTouchEventHandler(this);
+        oldDocument->didRemoveTouchEventHandler(*this);
+        document().didAddTouchEventHandler(*this);
     }
 
@@ -1747 +1747 @@
 
     targetNode->document().addListenerTypeIfNeeded(eventType);
-    if (eventType == eventNames().wheelEvent || eventType == eventNames().mousewheelEvent)
-        targetNode->document().didAddWheelEventHandler();
+    if (eventNames().isWheelEventType(eventType))
+        targetNode->document().didAddWheelEventHandler(*targetNode);
     else if (eventNames().isTouchEventType(eventType))
-        targetNode->document().didAddTouchEventHandler(targetNode);
+        targetNode->document().didAddTouchEventHandler(*targetNode);
 
 #if PLATFORM(IOS)
@@ -1789 +1789 @@
     // FIXME: Notify Document that the listener has vanished. We need to keep track of a number of
     // listeners for each type, not just a bool - see https://bugs.webkit.org/show_bug.cgi?id=33861
-    if (eventType == eventNames().wheelEvent || eventType == eventNames().mousewheelEvent)
-        targetNode->document().didRemoveWheelEventHandler();
+    if (eventNames().isWheelEventType(eventType))
+        targetNode->document().didRemoveWheelEventHandler(*targetNode);
     else if (eventNames().isTouchEventType(eventType))
-        targetNode->document().didRemoveTouchEventHandler(targetNode);
+        targetNode->document().didRemoveTouchEventHandler(*targetNode);
 
 #if PLATFORM(IOS)
@@ -2087 +2087 @@
         }
 #endif
-    } else if ((eventType == eventNames().wheelEvent || eventType == eventNames().mousewheelEvent) && is<WheelEvent>(*event)) {
-
+    } else if (eventNames().isWheelEventType(eventType) && is<WheelEvent>(*event)) {
         // If we don't have a renderer, send the wheel event to the first node we find with a renderer.
         // This is needed for <option> and <optgroup> elements so that <select>s get a wheel scroll.

trunk/Source/WebCore/history/CachedFrame.cpp

@@ -117 +117 @@
         if (DOMWindow* domWindow = m_document->domWindow()) {
             // FIXME: Add SCROLL_LISTENER to the list of event types on Document, and use m_document->hasListenerType(). See <rdar://problem/9615482>.
+            // FIXME: Can use Document::hasListenerType() now.
             if (domWindow->scrollEventListenerCount() && frame.page())
                 frame.page()->chrome().client().setNeedsScrollNotifications(&frame, true);

trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp

@@ -589 +589 @@
     if (event->type() == eventNames().clickEvent)
         m_mediaControls->handleClickEvent(event);
-    else if ((event->type() == eventNames().wheelEvent || event->type() == eventNames().mousewheelEvent) && is<WheelEvent>(*event)) {
+    else if (eventNames().isWheelEventType(event->type()) && is<WheelEvent>(*event)) {
         WheelEvent& wheelEvent = downcast<WheelEvent>(*event);
         if (m_mediaControls->shouldClosedCaptionsContainerPreventPageScrolling(wheelEvent.wheelDeltaY()))

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -1698 +1698 @@
     if (Document* document = this->document()) {
         document->addListenerTypeIfNeeded(eventType);
-        if (eventType == eventNames().wheelEvent || eventType == eventNames().mousewheelEvent)
-            document->didAddWheelEventHandler();
+        if (eventNames().isWheelEventType(eventType))
+            document->didAddWheelEventHandler(*document);
         else if (eventNames().isTouchEventType(eventType))
-            document->didAddTouchEventHandler(document);
+            document->didAddTouchEventHandler(*document);
         else if (eventType == eventNames().storageEvent)
             didAddStorageEventListener(this);
@@ -1789 +1789 @@
 
     if (Document* document = this->document()) {
-        if (eventType == eventNames().wheelEvent || eventType == eventNames().mousewheelEvent)
-            document->didRemoveWheelEventHandler();
+        if (eventNames().isWheelEventType(eventType))
+            document->didRemoveWheelEventHandler(*document);
         else if (eventNames().isTouchEventType(eventType))
-            document->didRemoveTouchEventHandler(document);
+            document->didRemoveTouchEventHandler(*document);
     }
 

trunk/Source/WebCore/page/ios/FrameIOS.mm

@@ -274 +274 @@
 }
 
-#define ALLOW_SCROLL_LISTENERS 0
-
 static Node* ancestorRespondingToScrollWheelEvents(const HitTestResult& hitTestResult, Node* terminationNode, IntRect* nodeBounds)
 {
@@ -283 +281 @@
     Node* scrollingAncestor = nullptr;
     for (Node* node = hitTestResult.innerNode(); node && node != terminationNode && !node->hasTagName(HTMLNames::bodyTag); node = node->parentNode()) {
-#if ALLOW_SCROLL_LISTENERS
-        if (node->willRespondToMouseWheelEvents()) {
-            scrollingAncestor = node;
-            continue;
-        }
-#endif
-
         RenderObject* renderer = node->renderer();
         if (!renderer)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-03-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Clean up related to wheelEvent names
+        https://bugs.webkit.org/show_bug.cgi?id=142713
+
+        Reviewed by Anders Carlsson.
+
+        Add EventNames::isWheelEventType() and use it in places that test for the
+        two wheel event names.
+
+        * WebProcess/Plugins/PluginView.cpp:
+        (WebKit::PluginView::handleEvent):
+
 2015-03-15  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp

@@ -920 +920 @@
         if (event->type() != eventNames().mousemoveEvent)
             pluginDidReceiveUserInteraction();
-    } else if ((event->type() == eventNames().wheelEvent || event->type() == eventNames().mousewheelEvent)
+    } else if (eventNames().isWheelEventType(event->type())
         && currentEvent->type() == WebEvent::Wheel && m_plugin->wantsWheelEvents()) {
         didHandleEvent = m_plugin->handleWheelEvent(static_cast<const WebWheelEvent&>(*currentEvent));