Changeset 181897 in webkit


Ignore:
Timestamp:
Mar 24, 2015 10:25:31 AM (9 years ago)
Author:
yoav@yoav.ws
Message:

Stop image from displaying when src attribute is removed or emptied
​https://bugs.webkit.org/show_bug.cgi?id=142677

Reviewed by Chris Dumez.

Source/WebCore:

Previously, we ignored empty attribute as failed URL, and didn't update the
renderer when an image was removed. This patch fixes that.

Tests: fast/dom/HTMLImageElement/image-empty-src.html

fast/dom/HTMLImageElement/image-remove-src.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

LayoutTests:

  • fast/dom/HTMLImageElement/image-empty-src-expected.html: Added.
  • fast/dom/HTMLImageElement/image-empty-src.html: Added.
  • fast/dom/HTMLImageElement/image-remove-src-expected.html: Added.
  • fast/dom/HTMLImageElement/image-remove-src.html: Added.
  • fast/dom/HTMLImageElement/image-empty-srcset-expected.html: Added.
  • fast/dom/HTMLImageElement/image-empty-srcset.html: Added.
  • fast/dom/HTMLImageElement/image-remove-srcset-expected.html: Added.
  • fast/dom/HTMLImageElement/image-remove-srcset.html: Added.
Location:
trunk
Files:
8 added
1 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r181896 r181897  
     12015-03-24  Yoav Weiss  <yoav@yoav.ws>
     2
     3        Stop image from displaying when src attribute is removed or emptied
     4        https://bugs.webkit.org/show_bug.cgi?id=142677
     5
     6        Reviewed by Chris Dumez.
     7
     8        * fast/dom/HTMLImageElement/image-empty-src-expected.html: Added.
     9        * fast/dom/HTMLImageElement/image-empty-src.html: Added.
     10        * fast/dom/HTMLImageElement/image-remove-src-expected.html: Added.
     11        * fast/dom/HTMLImageElement/image-remove-src.html: Added.
     12        * fast/dom/HTMLImageElement/image-empty-srcset-expected.html: Added.
     13        * fast/dom/HTMLImageElement/image-empty-srcset.html: Added.
     14        * fast/dom/HTMLImageElement/image-remove-srcset-expected.html: Added.
     15        * fast/dom/HTMLImageElement/image-remove-srcset.html: Added.
     16
    1172015-03-24  Brent Fulgham  <bfulgham@apple.com>
    218

  • trunk/LayoutTests/TestExpectations

    r181888 r181897  
    494494# contentfiltering/block-after-add-data.html times out unexpectedly
    495495webkit.org/b/142894 contentfiltering/block-after-add-data.html [ Skip ]
    496 webkit.org/b/142677 canvas/philip/tests/2d.pattern.image.incomplete.removedsrc.html [ Failure ]

  • trunk/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt

    r71481 r181897  
    11Passed
     2

  • trunk/Source/WebCore/ChangeLog

    r181893 r181897  
     12015-03-24  Yoav Weiss  <yoav@yoav.ws>
     2
     3        Stop image from displaying when src attribute is removed or emptied
     4        https://bugs.webkit.org/show_bug.cgi?id=142677
     5
     6        Reviewed by Chris Dumez.
     7
     8        Previously, we ignored empty attribute as failed URL, and didn't update the
     9        renderer when an image was removed. This patch fixes that.
     10
     11        Tests: fast/dom/HTMLImageElement/image-empty-src.html
     12               fast/dom/HTMLImageElement/image-remove-src.html
     13
     14        * loader/ImageLoader.cpp:
     15        (WebCore::ImageLoader::updateFromElement):
     16
    1172015-03-17  Philippe Normand  <pnormand@igalia.com>
    218

  • trunk/Source/WebCore/loader/ImageLoader.cpp

    r181849 r181897  
    170170    AtomicString attr = element().imageSourceURL();
    171171
    172     if (attr == m_failedLoadURL)
     172    // Avoid loading a URL we already failed to load.
     173    if (!m_failedLoadURL.isEmpty() && attr == m_failedLoadURL)
    173174        return;
    174175
    … …  
    253254            newImage->addClient(this);
    254255        }
    255         if (oldImage)
     256        if (oldImage) {
    256257            oldImage->removeClient(this);
     258            updateRenderer();
     259        }
    257260    }
    258261
Note: See TracChangeset for help on using the changeset viewer.