Changeset 181930 in webkit
- Timestamp:
- Mar 24, 2015 9:27:33 PM (9 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 1 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r181929 r181930 1 2015-03-24 Joseph Pecoraro <pecoraro@apple.com> 2 3 Web Inspector: IndexedDB / Databases ContentViews should have refresh button 4 https://bugs.webkit.org/show_bug.cgi?id=142996 5 6 Reviewed by Timothy Hatcher. 7 8 * Localizations/en.lproj/localizedStrings.js: 9 Remove unused strings. 10 11 * UserInterface/Images/ReloadFull.svg: Added. 12 This is the same as Reload.svg but adjusted to fill the viewbox edge to edge. 13 The only change is to the viewbox. 14 15 * UserInterface/Protocol/RemoteObject.js: 16 (WebInspector.RemoteObject.prototype.release): 17 Some clients would call release not knowing if this was an object or not. 18 Act gracefully in the case that this was not an object that needs a 19 remote release. 20 21 * UserInterface/Views/DatabaseTableContentView.js: 22 (WebInspector.DatabaseTableContentView): 23 (WebInspector.DatabaseTableContentView.prototype.get navigationItems): 24 (WebInspector.DatabaseTableContentView.prototype._queryError): 25 (WebInspector.DatabaseTableContentView.prototype._refreshButtonClicked): 26 * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js: 27 (WebInspector.IndexedDatabaseObjectStoreContentView): 28 (WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems): 29 (WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData): 30 (WebInspector.IndexedDatabaseObjectStoreContentView.prototype._refreshButtonClicked): 31 Give the storage content views a refresh button to reload the content. 32 1 33 2015-03-24 Joseph Pecoraro <pecoraro@apple.com> 2 34 -
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
r181872 r181930 78 78 localizedStrings["Boundary"] = "Boundary"; 79 79 localizedStrings["Box Model"] = "Box Model"; 80 localizedStrings["Breakpoints"] = "Breakpoints";81 80 localizedStrings["Bubbling"] = "Bubbling"; 82 81 localizedStrings["Busy"] = "Busy"; … … 194 193 localizedStrings["Element is the root element"] = "Element is the root element"; 195 194 localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element"; 196 localizedStrings["Empty Collection"] = "Empty Collection";197 195 localizedStrings["Enable Breakpoint"] = "Enable Breakpoint"; 198 196 localizedStrings["Enable Breakpoints"] = "Enable Breakpoints"; -
trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js
r181061 r181930 503 503 release: function() 504 504 { 505 RuntimeAgent.releaseObject(this._objectId); 505 if (this._objectId) 506 RuntimeAgent.releaseObject(this._objectId); 506 507 }, 507 508 -
trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js
r178155 r181930 30 30 this.element.classList.add(WebInspector.DatabaseTableContentView.StyleClassName); 31 31 32 var refreshSource, refreshSize; 33 if (WebInspector.Platform.isLegacyMacOS) { 34 refreshSource = "Images/Legacy/Reload.svg"; 35 refreshSize = 16; 36 } else { 37 refreshSource = "Images/ReloadFull.svg"; 38 refreshSize = 13; 39 } 40 41 this._refreshButtonNavigationItem = new WebInspector.ButtonNavigationItem("database-table-refresh", WebInspector.UIString("Refresh"), refreshSource, refreshSize, refreshSize); 42 this._refreshButtonNavigationItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._refreshButtonClicked, this); 43 32 44 this.update(); 33 45 }; … … 37 49 WebInspector.DatabaseTableContentView.prototype = { 38 50 constructor: WebInspector.DatabaseTableContentView, 51 __proto__: WebInspector.ContentView.prototype, 39 52 40 53 // Public 54 55 get navigationItems() 56 { 57 return [this._refreshButtonNavigationItem]; 58 }, 41 59 42 60 get allowedNavigationSidebarPanels() … … 102 120 this.element.removeChildren(); 103 121 this.element.appendChild(WebInspector.createMessageTextView(WebInspector.UIString("An error occured trying to\nread the “%s” table.").format(this.representedObject.name), true)); 122 }, 123 124 _refreshButtonClicked: function() 125 { 126 this.update(); 104 127 } 105 128 }; 106 107 WebInspector.DatabaseTableContentView.prototype.__proto__ = WebInspector.ContentView.prototype; -
trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.js
r164543 r181930 67 67 68 68 this._dataGrid = new WebInspector.DataGrid(columnInfo); 69 this._dataGrid.scrollContainer.addEventListener("scroll", this._dataGridScrolled.bind(this)); 69 70 this.element.appendChild(this._dataGrid.element); 70 71 this._dataGrid.scrollContainer.addEventListener("scroll", this._dataGridScrolled.bind(this));72 71 73 72 this._entries = []; 74 73 75 74 this._fetchMoreData(); 75 76 var refreshSource, refreshSize; 77 if (WebInspector.Platform.isLegacyMacOS) { 78 refreshSource = "Images/Legacy/Reload.svg"; 79 refreshSize = 16; 80 } else { 81 refreshSource = "Images/ReloadFull.svg"; 82 refreshSize = 13; 83 } 84 85 this._refreshButtonNavigationItem = new WebInspector.ButtonNavigationItem("indexed-database-object-store-refresh", WebInspector.UIString("Refresh"), refreshSource, refreshSize, refreshSize); 86 this._refreshButtonNavigationItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._refreshButtonClicked, this); 76 87 }; 77 88 … … 83 94 84 95 // Public 96 97 get navigationItems() 98 { 99 return [this._refreshButtonNavigationItem]; 100 }, 85 101 86 102 closed: function() … … 149 165 150 166 WebInspector.storageManager.requestIndexedDatabaseData(this._objectStore, this._objectStoreIndex, this._entries.length, 25, processEntries.bind(this)); 167 }, 168 169 _refreshButtonClicked: function() 170 { 171 this._reset(); 172 this._fetchMoreData(); 151 173 } 152 174 };
Note: See TracChangeset
for help on using the changeset viewer.