Changeset 182077 in webkit

Timestamp:

Mar 27, 2015 2:02:31 PM (9 years ago)

Author:

ap@apple.com

Message:

Calling crypto.webkitSubtle.generateKey causes page memory to never be released
​https://bugs.webkit.org/show_bug.cgi?id=143151
rdar://problem/18940687

Reviewed by Tim Horton.

• crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::generatePair): Don't.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• crypto/mac/CryptoKeyRSAMac.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-27  Alexey Proskuryakov  <ap@apple.com>
+
+        Calling crypto.webkitSubtle.generateKey causes page memory to never be released
+        https://bugs.webkit.org/show_bug.cgi?id=143151
+        rdar://problem/18940687
+
+        Reviewed by Tim Horton.
+
+        * crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::generatePair): Don't.
+
 2015-03-27  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp

@@ -262 +262 @@
             callOnWebThreadOrDispatchAsyncOnMainThread(^{
                 (*localFailureCallback)();
+                delete localCallback;
                 delete localFailureCallback;
             });
@@ -271 +272 @@
             (*localCallback)(CryptoKeyPair::create(publicKey.release(), privateKey.release()));
             delete localCallback;
+            delete localFailureCallback;
         });
     });