Changeset 182091 in webkit

Timestamp:

Mar 27, 2015 5:40:56 PM (9 years ago)

Author:

msaboff@apple.com

Message:

Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64
​https://bugs.webkit.org/show_bug.cgi?id=138390

Reviewed by Mark Lam.

Source/JavaScriptCore:

Changed load8Signed() and load16Signed() to only sign extend the loaded value to 32 bits
instead of 64 bits. This is what X86-64 does.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load16Signed):
(JSC::MacroAssemblerARM64::load8Signed):

LayoutTests:

Reenabled the tests for ARM64/iOS. Left the tests disabled for ARM64/linux and will let linux
developers test and reenable under existing but ​https://bugs.webkit.org/show_bug.cgi?id=142629.

• js/script-tests/dfg-int16array.js:
• js/script-tests/dfg-int8array.js:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/script-tests/dfg-int16array.js (modified) (1 diff)
• LayoutTests/js/script-tests/dfg-int8array.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/assembler/MacroAssemblerARM64.h (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-03-27  Michael Saboff  <msaboff@apple.com>
+
+        Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64
+        https://bugs.webkit.org/show_bug.cgi?id=138390
+
+        Reviewed by Mark Lam.
+
+        Reenabled the tests for ARM64/iOS.  Left the tests disabled for ARM64/linux and will let linux
+        developers test and reenable under existing but https://bugs.webkit.org/show_bug.cgi?id=142629.
+
+        * js/script-tests/dfg-int16array.js:
+        * js/script-tests/dfg-int8array.js:
+
 2015-03-27  Jer Noble  <jer.noble@apple.com>
 

trunk/LayoutTests/js/script-tests/dfg-int16array.js

@@ -2 +2 @@
 // https://bugs.webkit.org/show_bug.cgi?id=142629
 
-// Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64
-// https://bugs.webkit.org/show_bug.cgi?id=138390
-
-//@ skip if $architecture == "arm64"
+//@ skip if $architecture == "arm64" and $hostOS == "linux"
 
 description(

trunk/LayoutTests/js/script-tests/dfg-int8array.js

@@ -2 +2 @@
 // https://bugs.webkit.org/show_bug.cgi?id=142629
 
-// Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64
-// https://bugs.webkit.org/show_bug.cgi?id=138390
-
-//@ skip if $architecture == "arm64"
+//@ skip if $architecture == "arm64" and $hostOS == "linux"
 
 description(

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-03-27  Michael Saboff  <msaboff@apple.com>
+
+        Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64
+        https://bugs.webkit.org/show_bug.cgi?id=138390
+
+        Reviewed by Mark Lam.
+
+        Changed load8Signed() and load16Signed() to only sign extend the loaded value to 32 bits
+        instead of 64 bits.  This is what X86-64 does.
+
+        * assembler/MacroAssemblerARM64.h:
+        (JSC::MacroAssemblerARM64::load16Signed):
+        (JSC::MacroAssemblerARM64::load8Signed):
+
 2015-03-27  Saam Barati  <saambarati1@gmail.com>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM64.h

@@ -922 +922 @@
     {
         if (!address.offset && (!address.scale || address.scale == 1)) {
-            m_assembler.ldrsh<64>(dest, address.base, address.index, ARM64Assembler::UXTX, address.scale);
+            m_assembler.ldrsh<32>(dest, address.base, address.index, ARM64Assembler::UXTX, address.scale);
             return;
         }
@@ -928 +928 @@
         signExtend32ToPtr(TrustedImm32(address.offset), getCachedMemoryTempRegisterIDAndInvalidate());
         m_assembler.add<64>(memoryTempRegister, memoryTempRegister, address.index, ARM64Assembler::UXTX, address.scale);
-        m_assembler.ldrsh<64>(dest, address.base, memoryTempRegister);
+        m_assembler.ldrsh<32>(dest, address.base, memoryTempRegister);
     }
 
@@ -963 +963 @@
     {
         if (!address.offset && !address.scale) {
-            m_assembler.ldrsb<64>(dest, address.base, address.index, ARM64Assembler::UXTX, address.scale);
+            m_assembler.ldrsb<32>(dest, address.base, address.index, ARM64Assembler::UXTX, address.scale);
             return;
         }
@@ -969 +969 @@
         signExtend32ToPtr(TrustedImm32(address.offset), getCachedMemoryTempRegisterIDAndInvalidate());
         m_assembler.add<64>(memoryTempRegister, memoryTempRegister, address.index, ARM64Assembler::UXTX, address.scale);
-        m_assembler.ldrsb<64>(dest, address.base, memoryTempRegister);
+        m_assembler.ldrsb<32>(dest, address.base, memoryTempRegister);
     }