Changeset 182364 in webkit

Timestamp:

Apr 5, 2015 1:17:11 PM (9 years ago)

Author:

Simon Fraser

Message:

Remove "go ahead and" from comments
​https://bugs.webkit.org/show_bug.cgi?id=143421

Reviewed by Darin Adler, Benjamin Poulain.

Remove the phrase "go ahead and" from comments where it doesn't add
anything (which is almost all of them).

Source/JavaScriptCore:

• interpreter/JSStack.cpp:

(JSC::JSStack::growSlowCase):

Source/WebCore:

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOriginLockFor):

• css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::isSupportedFormat):

• css/CSSPrimitiveValue.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::detachFromFrame):

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addIncrementalDataBuffer):

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::performURLImport):

• page/PageOverlay.cpp:

(WebCore::PageOverlay::fadeAnimationTimerFired):

• platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollContents):

• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::create):

• platform/graphics/GraphicsContext.cpp:
• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

• platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPRefresh):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
(WebCore::RenderBlock::addFocusRingRects):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::appendRunsForObject):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange):

• rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::dirtyRange):

• rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleText):

• rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::nextLineBreak):

• style/StyleResolveTree.cpp:

(WebCore::Style::resolveLocal):

• xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent):

• xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append):

Source/WebKit/mac:

• WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView updateScrollers]):

• WebView/WebHTMLView.mm:

(-[WebHTMLView insertText:]):

Source/WebKit2:

• Platform/unix/EnvironmentUtilities.cpp:

(WebKit::EnvironmentUtilities::stripValuesEndingWithString):

• PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didClose):

• UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/interpreter/JSStack.cpp (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/Modules/webdatabase/DatabaseTracker.cpp (modified) (1 diff)
• WebCore/css/CSSFontFaceSrcValue.cpp (modified) (1 diff)
• WebCore/css/CSSPrimitiveValue.h (modified) (1 diff)
• WebCore/css/StyleResolver.cpp (modified) (4 diffs)
• WebCore/editing/ApplyStyleCommand.cpp (modified) (1 diff)
• WebCore/loader/DocumentLoader.cpp (modified) (1 diff)
• WebCore/loader/cache/CachedImage.cpp (modified) (1 diff)
• WebCore/loader/icon/IconDatabase.cpp (modified) (1 diff)
• WebCore/page/PageOverlay.cpp (modified) (1 diff)
• WebCore/platform/ScrollView.cpp (modified) (2 diffs)
• WebCore/platform/graphics/DisplayRefreshMonitor.cpp (modified) (1 diff)
• WebCore/platform/graphics/GraphicsContext.cpp (modified) (1 diff)
• WebCore/platform/graphics/mac/ComplexTextController.cpp (modified) (1 diff)
• WebCore/platform/network/HTTPParsers.cpp (modified) (1 diff)
• WebCore/rendering/RenderBlock.cpp (modified) (9 diffs)
• WebCore/rendering/RenderBlockFlow.cpp (modified) (15 diffs)
• WebCore/rendering/RenderBlockLineLayout.cpp (modified) (1 diff)
• WebCore/rendering/RenderBox.cpp (modified) (3 diffs)
• WebCore/rendering/RenderBoxModelObject.cpp (modified) (1 diff)
• WebCore/rendering/RenderLayer.cpp (modified) (5 diffs)
• WebCore/rendering/RenderLayerModelObject.cpp (modified) (1 diff)
• WebCore/rendering/RenderLineBoxList.cpp (modified) (1 diff)
• WebCore/rendering/RenderTextLineBoxes.cpp (modified) (1 diff)
• WebCore/rendering/line/BreakingContext.h (modified) (3 diffs)
• WebCore/rendering/line/LineBreaker.cpp (modified) (1 diff)
• WebCore/style/StyleResolveTree.cpp (modified) (1 diff)
• WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp (modified) (1 diff)
• WebCore/xml/parser/XMLDocumentParser.cpp (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebDynamicScrollBarsView.mm (modified) (1 diff)
• WebKit/mac/WebView/WebHTMLView.mm (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Platform/unix/EnvironmentUtilities.cpp (modified) (1 diff)
• WebKit2/PluginProcess/PluginProcess.cpp (modified) (1 diff)
• WebKit2/UIProcess/API/mac/WKView.mm (modified) (3 diffs)
• WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-04-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove "go ahead and" from comments
+        https://bugs.webkit.org/show_bug.cgi?id=143421
+
+        Reviewed by Darin Adler, Benjamin Poulain.
+
+        Remove the phrase "go ahead and" from comments where it doesn't add
+        anything (which is almost all of them).
+
+        * interpreter/JSStack.cpp:
+        (JSC::JSStack::growSlowCase):
+
 2015-04-04  Andreas Kling  <akling@apple.com>
 

trunk/Source/JavaScriptCore/interpreter/JSStack.cpp

@@ -98 +98 @@
         return false;
 
-    // Otherwise, the growth is still within our budget. Go ahead and commit
-    // it and return true.
+    // Otherwise, the growth is still within our budget. Commit it and return true.
     m_reservation.commit(newCommitTop, delta);
     addToCommittedByteCount(delta);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove "go ahead and" from comments
+        https://bugs.webkit.org/show_bug.cgi?id=143421
+
+        Reviewed by Darin Adler, Benjamin Poulain.
+
+        Remove the phrase "go ahead and" from comments where it doesn't add
+        anything (which is almost all of them).
+
+        * Modules/webdatabase/DatabaseTracker.cpp:
+        (WebCore::DatabaseTracker::deleteOriginLockFor):
+        * css/CSSFontFaceSrcValue.cpp:
+        (WebCore::CSSFontFaceSrcValue::isSupportedFormat):
+        * css/CSSPrimitiveValue.h:
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::styleForKeyframe):
+        (WebCore::StyleResolver::styleForPage):
+        (WebCore::StyleResolver::applyMatchedProperties):
+        * editing/ApplyStyleCommand.cpp:
+        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
+        * loader/DocumentLoader.cpp:
+        (WebCore::DocumentLoader::detachFromFrame):
+        * loader/cache/CachedImage.cpp:
+        (WebCore::CachedImage::addIncrementalDataBuffer):
+        * loader/icon/IconDatabase.cpp:
+        (WebCore::IconDatabase::performURLImport):
+        * page/PageOverlay.cpp:
+        (WebCore::PageOverlay::fadeAnimationTimerFired):
+        * platform/ScrollView.cpp:
+        (WebCore::ScrollView::updateScrollbars):
+        (WebCore::ScrollView::scrollContents):
+        * platform/graphics/DisplayRefreshMonitor.cpp:
+        (WebCore::DisplayRefreshMonitor::create):
+        * platform/graphics/GraphicsContext.cpp:
+        * platform/graphics/mac/ComplexTextController.cpp:
+        (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
+        * platform/network/HTTPParsers.cpp:
+        (WebCore::parseHTTPRefresh):
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::removeChild):
+        (WebCore::RenderBlock::layoutPositionedObjects):
+        (WebCore::RenderBlock::selectionGaps):
+        (WebCore::RenderBlock::blockSelectionGaps):
+        (WebCore::RenderBlock::absoluteRects):
+        (WebCore::RenderBlock::absoluteQuads):
+        (WebCore::RenderBlock::addFocusRingRects):
+        * rendering/RenderBlockFlow.cpp:
+        (WebCore::RenderBlockFlow::layoutBlockChild):
+        (WebCore::RenderBlockFlow::handleAfterSideOfBlock):
+        (WebCore::RenderBlockFlow::adjustBlockChildForPagination):
+        (WebCore::RenderBlockFlow::insertFloatingObject):
+        (WebCore::RenderBlockFlow::addOverhangingFloats):
+        (WebCore::RenderBlockFlow::inlineSelectionGaps):
+        (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlockFlow::appendRunsForObject):
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::positionLineBox):
+        (WebCore::RenderBox::sizesLogicalWidthToFitContent):
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::updateLayerPositions):
+        (WebCore::RenderLayer::hitTestLayer):
+        (WebCore::RenderLayer::calculateClipRects):
+        * rendering/RenderLayerModelObject.cpp:
+        (WebCore::RenderLayerModelObject::styleWillChange):
+        * rendering/RenderLineBoxList.cpp:
+        (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
+        * rendering/RenderTextLineBoxes.cpp:
+        (WebCore::RenderTextLineBoxes::dirtyRange):
+        * rendering/line/BreakingContext.h:
+        (WebCore::BreakingContext::handleOutOfFlowPositioned):
+        (WebCore::BreakingContext::handleText):
+        * rendering/line/LineBreaker.cpp:
+        (WebCore::LineBreaker::nextLineBreak):
+        * style/StyleResolveTree.cpp:
+        (WebCore::Style::resolveLocal):
+        * xml/XMLHttpRequestProgressEventThrottle.cpp:
+        (WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent):
+        * xml/parser/XMLDocumentParser.cpp:
+        (WebCore::XMLDocumentParser::append):
+
 2015-04-04  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp

@@ -685 +685 @@
     // orderly clean up first when we remove its ref from the m_originLockMap.
     // This may or may not be possible depending on whether other threads are
-    // also using the OriginLock at the same time. After that, we will go ahead
-    // and delete the lock file.
+    // also using the OriginLock at the same time. After that, we will delete the lock file.
 
     m_originLockMap.remove(origin->databaseIdentifier());

trunk/Source/WebCore/css/CSSFontFaceSrcValue.cpp

@@ -54 +54 @@
 {
     // Normally we would just check the format, but in order to avoid conflicts with the old WinIE style of font-face,
-    // we will also check to see if the URL ends with .eot.  If so, we'll go ahead and assume that we shouldn't load it.
+    // we will also check to see if the URL ends with .eot. If so, we'll assume that we shouldn't load it.
     if (m_format.isEmpty()) {
         // Check for .eot.

trunk/Source/WebCore/css/CSSPrimitiveValue.h

@@ -60 +60 @@
 
 // Dimension calculations are imprecise, often resulting in values of e.g.
-// 44.99998. We need to go ahead and round if we're really close to the next
-// integer value.
+// 44.99998. We need to round if we're really close to the next integer value.
 template<typename T> inline T roundForImpreciseConversion(double value)
 {

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -869 +869 @@
     applyCascadedProperties(cascade, firstCSSProperty, lastHighPriorityProperty);
 
-    // If our font got dirtied, go ahead and update it now.
+    // If our font got dirtied, update it now.
     updateFont();
 
@@ -875 +875 @@
     applyCascadedProperties(cascade, firstLowPriorityProperty, lastCSSProperty);
 
-    // If our font got dirtied by one of the non-essential font props,
-    // go ahead and update it a second time.
+    // If our font got dirtied by one of the non-essential font props, update it a second time.
     updateFont();
 
@@ -1035 +1034 @@
     applyCascadedProperties(cascade, firstCSSProperty, lastHighPriorityProperty);
 
-    // If our font got dirtied, go ahead and update it now.
+    // If our font got dirtied, update it now.
     updateFont();
 
@@ -1791 +1790 @@
         return applyMatchedProperties(matchResult, element, DoNotUseMatchedPropertiesCache);
 
-    // If our font got dirtied, go ahead and update it now.
+    // If our font got dirtied, update it now.
     updateFont();
 

trunk/Source/WebCore/editing/ApplyStyleCommand.cpp

@@ -1066 +1066 @@
 
             // Apply style to all nodes containing targetNode and their siblings but NOT to targetNode
-            // But if we've removed styledElement then go ahead and always apply the style.
+            // But if we've removed styledElement then always apply the style.
             if (&child != targetNode || styledElement)
                 applyInlineStyleToPushDown(&child, styleToPushDown.get());

trunk/Source/WebCore/loader/DocumentLoader.cpp

@@ -907 +907 @@
 
     // It never makes sense to have a document loader that is detached from its
-    // frame have any loads active, so go ahead and kill all the loads.
+    // frame have any loads active, so kill all the loads.
     stopLoading();
     if (m_mainResource && m_mainResource->hasClient(this))

trunk/Source/WebCore/loader/cache/CachedImage.cpp

@@ -391 +391 @@
     }
 
-    // Go ahead and tell our observers to try to draw.
-    // Each chunk from the network causes observers to repaint, which will
-    // force that chunk to decode.
+    // Tell our observers to try to draw.
+    // Each chunk from the network causes observers to repaint, which will force that chunk to decode.
     // It would be nice to only redraw the decoded band of the image, but with the current design
     // (decoding delayed until painting) that seems hard.

trunk/Source/WebCore/loader/icon/IconDatabase.cpp

@@ -1222 +1222 @@
             // If the pageRecord doesn't exist in this map, then no one has retained this pageURL
             // If the s_databaseCleanupCounter count is non-zero, then we're not supposed to be pruning the database in any manner,
-            // so go ahead and actually create a pageURLRecord for this url even though it's not retained.
+            // so actually create a pageURLRecord for this url even though it's not retained.
             // If database cleanup *is* allowed, we don't want to bother pulling in a page url from disk that noone is actually interested
             // in - we'll prune it later instead!

trunk/Source/WebCore/page/PageOverlay.cpp

@@ -252 +252 @@
         m_fadeAnimationType = NoAnimation;
 
-        // If this was a fade out, go ahead and uninstall the page overlay.
+        // If this was a fade out, uninstall the page overlay.
         if (wasFadingOut)
             controller()->uninstallPageOverlay(this, PageOverlay::FadeMode::DoNotFade);

trunk/Source/WebCore/platform/ScrollView.cpp

@@ -605 +605 @@
     bool hasOverlayScrollbars = (!m_horizontalScrollbar || m_horizontalScrollbar->isOverlayScrollbar()) && (!m_verticalScrollbar || m_verticalScrollbar->isOverlayScrollbar());
 
-    // If we came in here with the view already needing a layout, then go ahead and do that
-    // first. (This will be the common case, e.g., when the page changes due to window resizing for example).
+    // If we came in here with the view already needing a layout then do that first.
+    // (This will be the common case, e.g., when the page changes due to window resizing for example).
     // This layout will not re-enter updateScrollbars and does not count towards our max layout pass total.
     if (!m_scrollbarsSuppressed && !hasOverlayScrollbars) {
@@ -840 +840 @@
             scrollContentsSlowPath(updateRect);
     } else { 
-       // We need to go ahead and repaint the entire backing store.  Do it now before moving the
-       // windowed plugins.
-       scrollContentsSlowPath(updateRect);
+        // We need to repaint the entire backing store. Do it now before moving the windowed plugins.
+        scrollContentsSlowPath(updateRect);
     }
 

trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp

@@ -43 +43 @@
         return monitor.value();
 
-    // If ChromeClient returned Nullopt, we'll go ahead and make one of the default type.
+    // If ChromeClient returned Nullopt, we'll make one of the default type.
 
 #if PLATFORM(MAC)

trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp

@@ -563 +563 @@
 
 #if !USE(CG)
-// Implement this if you want to go ahead and push the drawing mode into your native context
-// immediately.
+// Implement this if you want to go push the drawing mode into your native context immediately.
 void GraphicsContext::setPlatformTextDrawingMode(TextDrawingModeFlags)
 {

trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp

@@ -690 +690 @@
 
             if (hasExtraSpacing) {
-                // If we're a glyph with an advance, go ahead and add in letter-spacing.
+                // If we're a glyph with an advance, add in letter-spacing.
                 // That way we weed out zero width lurkers.  This behavior matches the fast text code path.
                 if (advance.width)

trunk/Source/WebCore/platform/network/HTTPParsers.cpp

@@ -224 +224 @@
             // https://bugs.webkit.org/show_bug.cgi?id=27868
             // Sometimes there is no closing quote for the end of the URL even though there was an opening quote.
-            // If we looped over the entire alleged URL string back to the opening quote, just go ahead and use everything
+            // If we looped over the entire alleged URL string back to the opening quote, just use everything
             // after the opening quote instead.
             if (urlEndPos == urlStartPos)

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -692 +692 @@
     }
 
-    // If this child is a block, and if our previous and next siblings are
-    // both anonymous blocks with inline content, then we can go ahead and
-    // fold the inline content back together.
+    // If this child is a block, and if our previous and next siblings are both anonymous blocks
+    // with inline content, then we can fold the inline content back together.
     RenderObject* prev = oldChild.previousSibling();
     RenderObject* next = oldChild.nextSibling();
@@ -748 +747 @@
     if (canMergeAnonymousBlocks && child && !child->previousSibling() && !child->nextSibling() && canCollapseAnonymousBlockChild()) {
         // The removal has knocked us down to containing only a single anonymous
-        // box.  We can go ahead and pull the content right back up into our
-        // box.
+        // box. We can pull the content right back up into our box.
         collapseAnonymousBoxChild(*this, downcast<RenderBlock>(child));
     } else if (((prev && prev->isAnonymousBlock()) || (next && next->isAnonymousBlock())) && canCollapseAnonymousBlockChild()) {
@@ -1332 +1330 @@
             r.clearNeedsLayout();
             
-        // If we are paginated or in a line grid, go ahead and compute a vertical position for our object now.
+        // If we are paginated or in a line grid, compute a vertical position for our object now.
         // If it's wrong we'll lay out again.
         LayoutUnit oldLogicalTop = 0;
@@ -1861 +1859 @@
         result = blockSelectionGaps(rootBlock, rootBlockPhysicalPosition, offsetFromRootBlock, lastLogicalTop, lastLogicalLeft, lastLogicalRight, cache, paintInfo);
 
-    // Go ahead and fill the vertical gap all the way to the bottom of our block if the selection extends past our block.
+    // Fill the vertical gap all the way to the bottom of our block if the selection extends past our block.
     if (&rootBlock == this && (selectionState() != SelectionBoth && selectionState() != SelectionEnd) && !isRubyBase() && !isRubyText()) {
         result.uniteCenter(blockSelectionGap(rootBlock, rootBlockPhysicalPosition, offsetFromRootBlock,
@@ -1881 +1879 @@
     GapRects result;
 
-    // Go ahead and jump right to the first block child that contains some selected objects.
+    // Jump right to the first block child that contains some selected objects.
     RenderBox* curr;
     for (curr = firstChildBox(); curr && curr->selectionState() == SelectionNone; curr = curr->nextSiblingBox()) { }
@@ -1937 +1935 @@
             lastLogicalRight = logicalRightSelectionOffset(rootBlock, curr->logicalBottom(), cache);
         } else if (childState != SelectionNone && is<RenderBlock>(*curr)) {
-            // We must be a block that has some selected object inside it.  Go ahead and recur.
+            // We must be a block that has some selected object inside it, so recur.
             result.unite(downcast<RenderBlock>(*curr).selectionGaps(rootBlock, rootBlockPhysicalPosition, LayoutSize(offsetFromRootBlock.width() + curr->x(), offsetFromRootBlock.height() + curr->y()),
                 lastLogicalTop, lastLogicalLeft, lastLogicalRight, childCache, paintInfo));
@@ -3313 +3311 @@
 void RenderBlock::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const
 {
-    // For blocks inside inlines, we go ahead and include margins so that we run right up to the
-    // inline boxes above and below us (thus getting merged with them to form a single irregular
-    // shape).
+    // For blocks inside inlines, we include margins so that we run right up to the inline boxes
+    // above and below us (thus getting merged with them to form a single irregular shape).
     if (isAnonymousBlockContinuation()) {
         // FIXME: This is wrong for block-flows that are horizontal.
@@ -3329 +3326 @@
 void RenderBlock::absoluteQuads(Vector<FloatQuad>& quads, bool* wasFixed) const
 {
-    // For blocks inside inlines, we go ahead and include margins so that we run right up to the
-    // inline boxes above and below us (thus getting merged with them to form a single irregular
-    // shape).
+    // For blocks inside inlines, we include margins so that we run right up to the inline boxes
+    // above and below us (thus getting merged with them to form a single irregular shape).
     FloatRect localRect = isAnonymousBlockContinuation() 
         ? FloatRect(0, -collapsedMarginBefore(), width(), height() + collapsedMarginBefore() + collapsedMarginAfter())
@@ -3414 +3410 @@
 void RenderBlock::addFocusRingRects(Vector<IntRect>& rects, const LayoutPoint& additionalOffset, const RenderLayerModelObject* paintContainer)
 {
-    // For blocks inside inlines, we go ahead and include margins so that we run right up to the
-    // inline boxes above and below us (thus getting merged with them to form a single irregular
-    // shape).
+    // For blocks inside inlines, we include margins so that we run right up to the inline boxes
+    // above and below us (thus getting merged with them to form a single irregular shape).
     if (inlineElementContinuation()) {
         // FIXME: This check really isn't accurate. 

trunk/Source/WebCore/rendering/RenderBlockFlow.cpp

@@ -672 +672 @@
     LayoutSize oldLayoutDelta = view().layoutDelta();
 #endif
-    // Go ahead and position the child as though it didn't collapse with the top.
+    // Position the child as though it didn't collapse with the top.
     setLogicalTopForChild(child, logicalTopEstimate, ApplyLayoutDelta);
     estimateRegionRangeForBoxChild(child);
@@ -729 +729 @@
     if (logicalTopAfterClear != logicalTopEstimate || child.needsLayout() || (paginated && childBlockFlow && childBlockFlow->shouldBreakAtLineToAvoidWidow())) {
         if (child.shrinkToAvoidFloats()) {
-            // The child's width depends on the line width.
-            // When the child shifts to clear an item, its width can
-            // change (because it has more available line width).
-            // So go ahead and mark the item as dirty.
+            // The child's width depends on the line width. When the child shifts to clear an item, its width can
+            // change (because it has more available line width). So mark the item as dirty.
             child.setChildNeedsLayout(MarkOnlyThis);
         }
@@ -1313 +1311 @@
         setLogicalHeight(logicalHeight() - downcast<RenderBlockFlow>(*lastBlock).marginOffsetForSelfCollapsingBlock());
 
-    // If we can't collapse with children then go ahead and add in the bottom margin.
+    // If we can't collapse with children then add in the bottom margin.
     if (!marginInfo.discardMargin() && (!marginInfo.canCollapseWithMarginAfter() && !marginInfo.canCollapseWithMarginBefore()
         && (!document().inQuirksMode() || !marginInfo.quirkContainer() || !marginInfo.hasMarginAfterQuirk())))
@@ -1527 +1525 @@
 
         if (child.shrinkToAvoidFloats()) {
-            // The child's width depends on the line width.
-            // When the child shifts to clear an item, its width can
-            // change (because it has more available line width).
-            // So go ahead and mark the item as dirty.
+            // The child's width depends on the line width. When the child shifts to clear an item, its width can
+            // change (because it has more available line width). So mark the item as dirty.
             child.setChildNeedsLayout(MarkOnlyThis);
         }
@@ -1589 +1585 @@
     }
 
-    // Similar to how we apply clearance. Go ahead and boost height() to be the place where we're going to position the child.
+    // Similar to how we apply clearance. Boost height() to be the place where we're going to position the child.
     setLogicalHeight(logicalHeight() + (result - oldTop));
     
@@ -2232 +2228 @@
     std::unique_ptr<FloatingObject> floatingObject = FloatingObject::create(floatBox);
     
-    // Our location is irrelevant if we're unsplittable or no pagination is in effect.
-    // Just go ahead and lay out the float.
+    // Our location is irrelevant if we're unsplittable or no pagination is in effect. Just lay out the float.
     bool isChildRenderBlock = floatBox.isRenderBlock();
     if (isChildRenderBlock && !floatBox.needsLayout() && view().layoutState()->pageLogicalHeightChanged())
@@ -2663 +2658 @@
             }
             
-            // Since the float doesn't overhang, it didn't get put into our list. We need to go ahead and add its overflow in to the
-            // child now.
+            // Since the float doesn't overhang, it didn't get put into our list. We need to add its overflow in to the child now.
             if (floatingObject->isDescendant())
                 child.addOverflowFromChild(&floatingObject->renderer(), LayoutSize(xPositionForFloatIncludingMargin(floatingObject), yPositionForFloatIncludingMargin(floatingObject)));
@@ -3058 +3052 @@
     if (!hasLines()) {
         if (containsStart) {
-            // Go ahead and update our lastLogicalTop to be the bottom of the block.  <hr>s or empty blocks with height can trip this
-            // case.
+            // Update our lastLogicalTop to be the bottom of the block. <hr>s or empty blocks with height can trip this case.
             lastLogicalTop = blockDirectionOffset(rootBlock, offsetFromRootBlock) + logicalHeight();
             lastLogicalLeft = logicalLeftSelectionOffset(rootBlock, logicalHeight(), cache);
@@ -3095 +3088 @@
 
     if (lastSelectedLine && selectionState() != SelectionEnd && selectionState() != SelectionBoth) {
-        // Go ahead and update our lastY to be the bottom of the last selected line.
+        // Update our lastY to be the bottom of the last selected line.
         lastLogicalTop = blockDirectionOffset(rootBlock, offsetFromRootBlock) + lastSelectedLine->selectionBottom();
         lastLogicalLeft = logicalLeftSelectionOffset(rootBlock, lastSelectedLine->selectionBottom(), cache);
@@ -4031 +4024 @@
         
         if (!child->isBR()) {
-            // Step One: determine whether or not we need to go ahead and
-            // terminate our current line. Each discrete chunk can become
-            // the new min-width, if it is the widest chunk seen so far, and
-            // it can also become the max-width.
+            // Step One: determine whether or not we need to terminate our current line.
+            // Each discrete chunk can become the new min-width, if it is the widest chunk
+            // seen so far, and it can also become the max-width.
 
             // Children fall into three categories:
@@ -4043 +4035 @@
             // (2) An inline non-text non-flow object, e.g., an inline replaced element.
             // These objects can always be on a line by themselves, so in this situation
-            // we need to go ahead and break the current line, and then add in our own
-            // margins and min/max width on its own line, and then terminate the line.
+            // we need to break the current line, and then add in our own margins and min/max
+            // width on its own line, and then terminate the line.
             //
             // (3) A text object. Text runs can have breakable characters at the start,
@@ -4056 +4048 @@
             // (c) the min/max width of the string (trimmed for whitespace).
             //
-            // If the text string starts with whitespace, then we need to go ahead and
-            // terminate our current line (unless we're already in a whitespace stripping
-            // mode.
+            // If the text string starts with whitespace, then we need to terminate our current line
+            // (unless we're already in a whitespace stripping mode.
             //
             // If the text string has a breakable character in the middle, but didn't start
@@ -4104 +4095 @@
             if (!is<RenderInline>(*child) && !is<RenderText>(*child)) {
                 // Case (2). Inline replaced elements and floats.
-                // Go ahead and terminate the current line as far as
-                // minwidth is concerned.
+                // Terminate the current line as far as minwidth is concerned.
                 childMin += child->minPreferredLogicalWidth().ceilToFloat();
                 childMax += child->maxPreferredLogicalWidth().ceilToFloat();
@@ -4241 +4231 @@
                     // we start and end with whitespace.
                     if (beginWS) {
-                        // Go ahead and end the current line.
+                        // End the current line.
                         minLogicalWidth = preferredWidth(minLogicalWidth, inlineMin);
                     } else {
@@ -4252 +4242 @@
 
                     if (endWS) {
-                        // We end in whitespace, which means we can go ahead
-                        // and end our current line.
+                        // We end in whitespace, which means we can end our current line.
                         minLogicalWidth = preferredWidth(minLogicalWidth, inlineMin);
                         inlineMin = 0;

trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -104 +104 @@
         }
 
-        // An end midpoint has been encountered within our object.  We
-        // need to go ahead and append a run with our endpoint.
+        // An end midpoint has been encountered within our object. We need to append a run with our endpoint.
         if (static_cast<int>(nextMidpoint.offset() + 1) <= end) {
             lineMidpointState.setBetweenMidpoints(true);

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -2083 +2083 @@
             rootBox.blockFlow().setStaticInlinePositionForChild(*this, rootBox.lineTopWithLeading(), LayoutUnit::fromFloatRound(box.logicalLeft()));
             if (style().hasStaticInlinePosition(box.isHorizontal()))
-                setChildNeedsLayout(MarkOnlyThis); // Just go ahead and mark the positioned object as needing layout, so it will update its position properly.
+                setChildNeedsLayout(MarkOnlyThis); // Just mark the positioned object as needing layout, so it will update its position properly.
         } else {
             // Our object was a block originally, so we make our normal flow position be
@@ -2091 +2091 @@
             layer()->setStaticBlockPosition(box.logicalTop());
             if (style().hasStaticBlockPosition(box.isHorizontal()))
-                setChildNeedsLayout(MarkOnlyThis); // Just go ahead and mark the positioned object as needing layout, so it will update its position properly.
+                setChildNeedsLayout(MarkOnlyThis); // Just mark the positioned object as needing layout, so it will update its position properly.
         }
 
@@ -2489 +2489 @@
 
     // Flexible box items should shrink wrap, so we lay them out at their intrinsic widths.
-    // In the case of columns that have a stretch alignment, we go ahead and layout at the
-    // stretched size to avoid an extra layout when applying alignment.
+    // In the case of columns that have a stretch alignment, we layout at the stretched size
+    // to avoid an extra layout when applying alignment.
     if (parent()->isFlexibleBox()) {
         // For multiline columns, we need to apply align-content first, so we can't stretch now.

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -814 +814 @@
                 backgroundRect.intersect(paintInfo.rect);
 
-            // If we have an alpha and we are painting the root element, go ahead and blend with the base background color.
+            // If we have an alpha and we are painting the root element, blend with the base background color.
             Color baseColor;
             bool shouldClearBackground = false;

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -537 +537 @@
     m_has3DTransformedAncestor = flags & Seen3DTransformedLayer;
 
-    // Go ahead and update the reflection's position and size.
+    // Update the reflection's position and size.
     if (m_reflection)
         m_reflection->layout();
@@ -5007 +5007 @@
             ClipRectsContext clipRectsContext(rootLayer, RootRelativeClipRects, IncludeOverlayScrollbarSize);
             ClipRect clipRect = backgroundClipRect(clipRectsContext);
-            // Go ahead and test the enclosing clip now.
+            // Test the enclosing clip now.
             if (!clipRect.intersects(hitTestLocation))
                 return nullptr;
@@ -5604 +5604 @@
 
         if (renderer().hasClip()) {
-            // Clip applies to *us* as well, so go ahead and update the damageRect.
+            // Clip applies to *us* as well, so update the damageRect.
             LayoutRect newPosClip = downcast<RenderBox>(renderer()).clipRect(toLayoutPoint(offsetFromRootLocal), namedFlowFragment);
             backgroundRect.intersect(newPosClip);
@@ -5611 +5611 @@
         }
 
-        // If we establish a clip at all, then go ahead and make sure our background
-        // rect is intersected with our layer's bounds including our visual overflow,
+        // If we establish a clip at all, then make sure our background rect is intersected with our layer's bounds including our visual overflow,
         // since any visual overflow like box-shadow or border-outset is not clipped by overflow:auto/hidden.
         if (renderBox()->hasVisualOverflow()) {
@@ -5740 +5739 @@
         return false;
 
-    // If we aren't an inline flow, and our layer bounds do intersect the damage rect, then we 
-    // can go ahead and return true.
+    // If we aren't an inline flow, and our layer bounds do intersect the damage rect, then we can return true.
     if (!renderer().isRenderInline()) {
         LayoutRect b = layerBounds;

trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp

@@ -102 +102 @@
 
         if (diff == StyleDifferenceLayout || diff == StyleDifferenceSimplifiedLayout) {
-            // When a layout hint happens, we go ahead and do a repaint of the layer, since the layer could
-            // end up being destroyed.
+            // When a layout hint happens, we do a repaint of the layer, since the layer could end up being destroyed.
             if (hasLayer()) {
                 if (oldStyle->position() != newStyle.position()

trunk/Source/WebCore/rendering/RenderLineBoxList.cpp

@@ -316 +316 @@
     // If we have no first line box, then just bail early.
     if (!firstBox) {
-        // For an empty inline, go ahead and propagate the check up to our parent, unless the parent
-        // is already dirty.
+        // For an empty inline, propagate the check up to our parent, unless the parent is already dirty.
         if (container.isInline() && !container.ancestorLineBoxDirty()) {
             container.parent()->dirtyLinesFromChangedChild(container);

trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp

@@ -634 +634 @@
                 firstRootBox = &rootBox;
                 if (!dirtiedLines) {
-                    // The affected area was in between two runs. Go ahead and mark the root box of
-                    // the run after the affected area as dirty.
+                    // The affected area was in between two runs. Mark the root box of the run after the affected area as dirty.
                     firstRootBox->markDirty();
                     dirtiedLines = true;

trunk/Source/WebCore/rendering/line/BreakingContext.h

@@ -384 +384 @@
 inline void BreakingContext::handleOutOfFlowPositioned(Vector<RenderBox*>& positionedObjects)
 {
-    // If our original display wasn't an inline type, then we can
-    // go ahead and determine our static inline position now.
+    // If our original display wasn't an inline type, then we can determine our static inline position now.
     auto& box = downcast<RenderBox>(*m_current.renderer());
     bool isInlineType = box.style().isOriginalDisplayInlineType();
@@ -391 +390 @@
         m_block.setStaticInlinePositionForChild(box, m_block.logicalHeight(), m_block.startOffsetForContent(m_block.logicalHeight()));
     else {
-        // If our original display was an INLINE type, then we can go ahead
-        // and determine our static y position now.
+        // If our original display was an INLINE type, then we can determine our static y position now.
         box.layer()->setStaticBlockPosition(m_block.logicalHeight());
     }
@@ -921 +919 @@
 
             if (!m_ignoringSpaces && m_currentStyle->collapseWhiteSpace()) {
-                // If we encounter a newline, or if we encounter a
-                // second space, we need to go ahead and break up this
-                // run and enter a mode where we start collapsing spaces.
+                // If we encounter a newline, or if we encounter a second space,
+                // we need to break up this run and enter a mode where we start collapsing spaces.
                 if (m_currentCharacterIsSpace && previousCharacterIsSpace) {
                     m_ignoringSpaces = true;

trunk/Source/WebCore/rendering/line/LineBreaker.cpp

@@ -109 +109 @@
         } else if (context.currentObject()->isText()) {
             if (context.handleText(wordMeasurements, m_hyphenated, consecutiveHyphenatedLines)) {
-                // We've hit a hard text line break. Our line break iterator is updated, so go ahead and early return.
+                // We've hit a hard text line break. Our line break iterator is updated, so early return.
                 return context.lineBreak();
             }

trunk/Source/WebCore/style/StyleResolveTree.cpp

@@ -772 +772 @@
     }
 
-    // If "rem" units are used anywhere in the document, and if the document element's font size changes, then go ahead and force font updating
+    // If "rem" units are used anywhere in the document, and if the document element's font size changes, then force font updating
     // all the way down the tree. This is simpler than having to maintain a cache of objects (and such font size changes should be rare anyway).
     if (document.styleSheetCollection().usesRemUnits() && document.documentElement() == &current && localChange != NoChange && currentStyle && newStyle && currentStyle->fontSize() != newStyle->fontSize()) {

trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp

@@ -67 +67 @@
 
     if (!isActive()) {
-        // The timer is not active so the least frequent event for now is every byte.
-        // Just go ahead and dispatch the event.
+        // The timer is not active so the least frequent event for now is every byte. Just dispatch the event.
 
         // We should not have any throttled progress event.

trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp

@@ -122 +122 @@
     doWrite(source.toString());
 
-    // After parsing, go ahead and dispatch image beforeload events.
+    // After parsing, dispatch image beforeload events.
     ImageLoader::dispatchPendingBeforeLoadEvents();
 }

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2015-04-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove "go ahead and" from comments
+        https://bugs.webkit.org/show_bug.cgi?id=143421
+
+        Reviewed by Darin Adler, Benjamin Poulain.
+
+        Remove the phrase "go ahead and" from comments where it doesn't add
+        anything (which is almost all of them).
+
+        * WebView/WebDynamicScrollBarsView.mm:
+        (-[WebDynamicScrollBarsView updateScrollers]):
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView insertText:]):
+
 2015-04-02  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm

@@ -286 +286 @@
     NSView *documentView = [self documentView];
 
-    // If we came in here with the view already needing a layout, then go ahead and do that
-    // first.  (This will be the common case, e.g., when the page changes due to window resizing for example).
+    // If we came in here with the view already needing a layout, then do that first.
+    // (This will be the common case, e.g., when the page changes due to window resizing for example).
     // This layout will not re-enter updateScrollers and does not count towards our max layout pass total.
     if (!_private->suppressLayout && !_private->suppressScrollers && [documentView isKindOfClass:[WebHTMLView class]]) {

trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

@@ -6403 +6403 @@
     // insertText can be called for several reasons:
     // - If it's from normal key event processing (including key bindings), we may need to save the action to perform it later.
-    // - If it's from an input method, then we should go ahead and insert the text now. We assume it's from the input method if we have marked text.
+    // - If it's from an input method, then we should insert the text now. We assume it's from the input method if we have marked text.
     // FIXME: In theory, this could be wrong for some input methods, so we should try to find another way to determine if the call is from the input method.
     // - If it's sent outside of keyboard event processing (e.g. from Character Viewer, or when confirming an inline input area with a mouse),

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-04-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove "go ahead and" from comments
+        https://bugs.webkit.org/show_bug.cgi?id=143421
+
+        Reviewed by Darin Adler, Benjamin Poulain.
+
+        Remove the phrase "go ahead and" from comments where it doesn't add
+        anything (which is almost all of them).
+
+        * Platform/unix/EnvironmentUtilities.cpp:
+        (WebKit::EnvironmentUtilities::stripValuesEndingWithString):
+        * PluginProcess/PluginProcess.cpp:
+        (WebKit::PluginProcess::didClose):
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView insertText:replacementRange:]):
+        (-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
+        * UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
+        (WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):
+
 2015-04-05  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebKit2/Platform/unix/EnvironmentUtilities.cpp

@@ -72 +72 @@
         // Copy over everything right of the match to the current component start, and search from there again.
         if (componentStart[0] == ':') {
-            // If componentStart points to a colon, go ahead and copy the colon over.
+            // If componentStart points to a colon, copy the colon over.
             strcpy(componentStart, match + searchLength);
         } else {

trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp

@@ -125 +125 @@
 void PluginProcess::didClose(IPC::Connection&)
 {
-    // The UI process has crashed, just go ahead and quit.
+    // The UI process has crashed, just quit.
     // FIXME: If the plug-in is spinning in the main loop, we'll never get this message.
     stopRunLoop();

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -1609 +1609 @@
     // insertText can be called for several reasons:
     // - If it's from normal key event processing (including key bindings), we save the action to perform it later.
-    // - If it's from an input method, then we should go ahead and insert the text now.
+    // - If it's from an input method, then we should insert the text now.
     // - If it's sent outside of keyboard event processing (e.g. from Character Viewer, or when confirming an inline input area with a mouse),
     // then we also execute it immediately, as there will be no other chance.
@@ -2079 +2079 @@
     // insertText can be called for several reasons:
     // - If it's from normal key event processing (including key bindings), we may need to save the action to perform it later.
-    // - If it's from an input method, then we should go ahead and insert the text now. We assume it's from the input method if we have marked text.
+    // - If it's from an input method, then we should insert the text now. We assume it's from the input method if we have marked text.
     // FIXME: In theory, this could be wrong for some input methods, so we should try to find another way to determine if the call is from the input method.
     // - If it's sent outside of keyboard event processing (e.g. from Character Viewer, or when confirming an inline input area with a mouse),
@@ -3395 +3395 @@
 
     if (inputSourceChanged) {
-        // The input source changed, go ahead and discard any entered text.
+        // The input source changed; discard any entered text.
         [[WKTextInputWindowController sharedTextInputWindowController] unmarkText];
     }

trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp

@@ -343 +343 @@
     m_origins.remove(originIdentifier);
     if (m_origins.isEmpty()) {
-        // There are no origins left, go ahead and delete the tracker database.
+        // There are no origins left; delete the tracker database.
         m_database.close();
         deleteFile(trackerDatabasePath());