Changeset 183224 in webkit

Timestamp:

Apr 23, 2015 3:54:02 PM (9 years ago)

Author:

Simon Fraser

Message:

Changing TiledBacking velocity should schedule a tile revalidation
​https://bugs.webkit.org/show_bug.cgi?id=144123

Reviewed by Tim Horton.
Source/WebCore:

Changing the velocity parameters on the TileController affect the computed
coverage rect, so whenever we make a change to velocity data that could
affect the outcome (basically any non-zero old or new velocities),
schedule a layer flush.

• platform/graphics/TiledBacking.h:

(WebCore::VelocityData::velocityOrScaleIsChanging):

• platform/graphics/ca/TileController.cpp:

(WebCore::TileController::setVelocity):

Source/WebKit2:

Drive-by fix: use the FrameView& that we have already.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/TiledBacking.h (modified) (1 diff)
• WebCore/platform/graphics/ca/TileController.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-23  Simon Fraser  <simon.fraser@apple.com>
+
+        Changing TiledBacking velocity should schedule a tile revalidation
+        https://bugs.webkit.org/show_bug.cgi?id=144123
+
+        Reviewed by Tim Horton.
+
+        Changing the velocity parameters on the TileController affect the computed
+        coverage rect, so whenever we make a change to velocity data that could
+        affect the outcome (basically any non-zero old or new velocities),
+        schedule a layer flush.
+
+        * platform/graphics/TiledBacking.h:
+        (WebCore::VelocityData::velocityOrScaleIsChanging):
+        * platform/graphics/ca/TileController.cpp:
+        (WebCore::TileController::setVelocity):
+
 2015-04-23  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/graphics/TiledBacking.h

@@ -53 +53 @@
         , lastUpdateTime(updateTime)
     {
+    }
+    
+    bool velocityOrScaleIsChanging() const
+    {
+        return horizontalVelocity || verticalVelocity || scaleChangeRate;
     }
 };

trunk/Source/WebCore/platform/graphics/ca/TileController.cpp

@@ -202 +202 @@
 void TileController::setVelocity(const VelocityData& velocity)
 {
+    bool changeAffectsTileCoverage = m_velocity.velocityOrScaleIsChanging() || velocity.velocityOrScaleIsChanging();
     m_velocity = velocity;
+    
+    if (changeAffectsTileCoverage)
+        setNeedsRevalidateTiles();
 }
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-04-23  Simon Fraser  <simon.fraser@apple.com>
+
+        Changing TiledBacking velocity should schedule a tile revalidation
+        https://bugs.webkit.org/show_bug.cgi?id=144123
+
+        Reviewed by Tim Horton.
+        
+        Drive-by fix: use the FrameView& that we have already.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::updateVisibleContentRects):
+
 2015-04-23  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -2787 +2787 @@
 
     if (m_isInStableState)
-        m_page->mainFrame().view()->setCustomFixedPositionLayoutRect(enclosingIntRect(visibleContentRectUpdateInfo.customFixedPositionRect()));
+        frameView.setCustomFixedPositionLayoutRect(enclosingIntRect(visibleContentRectUpdateInfo.customFixedPositionRect()));
 
     if (!visibleContentRectUpdateInfo.isChangingObscuredInsetsInteractively())