Changeset 183385 in webkit


Ignore:
Timestamp:
Apr 26, 2015 10:39:56 PM (9 years ago)
Author:
Manuel Rego Casasnovas
Message:

[CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspos boxes as definite
​https://bugs.webkit.org/show_bug.cgi?id=144144

Reviewed by Darin Adler.

Source/WebCore:

Change order in hasDefiniteLogicalHeight() ifs to consider definite
absolutely positioned elements.

Test: fast/css-grid-layout/percent-track-breadths-regarding-container-size.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasDefiniteLogicalHeight):

LayoutTests:

Add new test case to check absolutely positioned elements.

  • fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt:
  • fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r183384 r183385  
     12015-04-26  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        [CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspos boxes as definite
     4        https://bugs.webkit.org/show_bug.cgi?id=144144
     5
     6        Reviewed by Darin Adler.
     7
     8        Add new test case to check absolutely positioned elements.
     9
     10        * fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt:
     11        * fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:
     12
    1132015-04-26  Ryosuke Niwa  <rniwa@webkit.org>
    214

  • trunk/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt

    r182780 r183385  
    4141XXX
    4242PASS
     43XX
     44XXXXX
     45XXX
     46PASS
     47XX
     48XXXXX
     49XXX
     50PASS

  • trunk/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html

    r182780 r183385  
    2222    width: 50%;
    2323    height: 50%;
     24}
     25
     26.absolutelyPositioned {
     27    position: absolute;
    2428}
    2529
    … …  
    115119
    116120    <div class="indefiniteSize">
     121        <div class="grid absolutelyPositioned">
     122            <div class="firstRowFirstColumn sizedToGridArea" data-expected-width="0" data-expected-height="0">XX</div>
     123            <div class="firstRowSecondColumn sizedToGridArea" data-expected-width="0" data-expected-height="0">XXXXX</div>
     124            <div class="firstRowThirdColumn sizedToGridArea" data-expected-width="0" data-expected-height="0">XXX</div>
     125        </div>
     126    </div>
     127
     128    <div class="unconstrainedContainer">
     129        <div class="grid absolutelyPositioned">
     130            <div class="firstRowFirstColumn sizedToGridArea" data-expected-width="0" data-expected-height="0">XX</div>
     131            <div class="firstRowSecondColumn sizedToGridArea" data-expected-width="0" data-expected-height="0">XXXXX</div>
     132            <div class="firstRowThirdColumn sizedToGridArea" data-expected-width="0" data-expected-height="0">XXX</div>
     133        </div>
     134    </div>
     135
     136    <div class="indefiniteSize">
    117137        <div class="grid indefiniteSize">
    118138            <div class="firstRowFirstColumn sizedToGridArea" data-expected-width="20" data-expected-height="10">XX</div>

  • trunk/Source/WebCore/ChangeLog

    r183381 r183385  
     12015-04-26  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        [CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspos boxes as definite
     4        https://bugs.webkit.org/show_bug.cgi?id=144144
     5
     6        Reviewed by Darin Adler.
     7
     8        Change order in hasDefiniteLogicalHeight() ifs to consider definite
     9        absolutely positioned elements.
     10
     11        Test: fast/css-grid-layout/percent-track-breadths-regarding-container-size.html
     12
     13        * rendering/RenderBox.cpp:
     14        (WebCore::RenderBox::hasDefiniteLogicalHeight):
     15
    1162015-04-26  Said Abou-Hallawa  <sabouhallawa@apple.com>
    217

  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r183370 r183385  
    45434543{
    45444544    const Length& logicalHeight = style().logicalHeight();
    4545     if (logicalHeight.isIntrinsicOrAuto())
    4546         return false;
    45474545    if (logicalHeight.isFixed())
    45484546        return true;
    … …  
    45554553        return overrideContainingBlockContentLogicalHeight() != -1;
    45564554#endif
     4555    if (logicalHeight.isIntrinsicOrAuto())
     4556        return false;
    45574557
    45584558    return percentageLogicalHeightIsResolvable(this);
Note: See TracChangeset for help on using the changeset viewer.