Changeset 183558 in webkit

Timestamp:

Apr 29, 2015 10:42:47 AM (9 years ago)

Author:

ap@apple.com

Message:

fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
​https://bugs.webkit.org/show_bug.cgi?id=144155

Reviewed by Andreas Kling.

• WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):

Make sure that test window is "visible" before each test. While there is no concrete
evidence that this is the problem indeed, the behavior is consistent with what would
happen for an invisible window. Also, WKTR obviously needs to do this to protect
against potential buggy tests that hide the window and don't show it.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-04-29  Alexey Proskuryakov  <ap@apple.com>
+
+        fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
+        https://bugs.webkit.org/show_bug.cgi?id=144155
+
+        Reviewed by Andreas Kling.
+
+        * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
+        Make sure that test window is "visible" before each test. While there is no concrete
+        evidence that this is the problem indeed, the behavior is consistent with what would
+        happen for an invisible window. Also, WKTR obviously needs to do this to protect
+        against potential buggy tests that hide the window and don't show it.
+
 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -696 +696 @@
     WKPageGroupRemoveAllUserContentFilters(WKPageGetPageGroup(m_mainWebView->page()));
 
+    setHidden(false);
+
     // Reset main page back to about:blank
     m_doneResetting = false;