Changeset 183678 in webkit

Timestamp:

May 1, 2015 10:05:51 AM (9 years ago)

Author:

jdiggs@igalia.com

Message:

AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes
​https://bugs.webkit.org/show_bug.cgi?id=144481

Reviewed by Chris Fleizach.

Canvas fallback content is allowed to be focusable if the canvas is displayed
and visible. Update the style when creating an accessible object for a node in
a canvas subtree and before Element::isFocusable() gets called.

No new tests. The existing, crashing test no longer crashes.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AXObjectCache.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes
+        https://bugs.webkit.org/show_bug.cgi?id=144481
+
+        Reviewed by Chris Fleizach.
+
+        Canvas fallback content is allowed to be focusable if the canvas is displayed
+        and visible. Update the style when creating an accessible object for a node in
+        a canvas subtree and before Element::isFocusable() gets called.
+
+        No new tests. The existing, crashing test no longer crashes.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::getOrCreate):
+
 2015-05-01  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/accessibility/AXObjectCache.cpp

@@ -398 +398 @@
         return nullptr;
 
+    // Fallback content is only focusable as long as the canvas is displayed and visible.
+    // Update the style before Element::isFocusable() gets called.
+    if (inCanvasSubtree)
+        node->document().updateStyleIfNeeded();
+
     RefPtr<AccessibilityObject> newObj = createFromNode(node);