Changeset 183741 in webkit

Timestamp:

May 4, 2015 1:51:25 AM (9 years ago)

Author:

Csaba Osztrogonác

Message:

[cmake] Disable GNU Gold linker on Cortex A53
​https://bugs.webkit.org/show_bug.cgi?id=144382

Reviewed by Carlos Garcia Campos.

• Source/cmake/OptionsCommon.cmake:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsCommon.cmake (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
+
+        [cmake] Disable GNU Gold linker on Cortex A53
+        https://bugs.webkit.org/show_bug.cgi?id=144382
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Source/cmake/OptionsCommon.cmake:
+
 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/cmake/OptionsCommon.cmake

@@ -62 +62 @@
         set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mfix-cortex-a53-835769")
         set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mfix-cortex-a53-835769")
-        message(STATUS "Enabling Cortex-A53 workaround for compiler")
+        message(STATUS "Enabling Cortex-A53 workaround for compiler and disabling GNU gold linker, because it doesn't support this workaround.")
     endif ()
 endif ()
@@ -69 +69 @@
 
 # Use ld.gold if it is available and isn't disabled explicitly
-option(USE_LD_GOLD "Use GNU gold linker" ON)
+include(CMakeDependentOption)
+CMAKE_DEPENDENT_OPTION(USE_LD_GOLD "Use GNU gold linker" ON
+                       "NOT CXX_ACCEPTS_MFIX_CORTEX_A53_835769" OFF)
 if (USE_LD_GOLD)
     execute_process(COMMAND ${CMAKE_C_COMPILER} -fuse-ld=gold -Wl,--version ERROR_QUIET OUTPUT_VARIABLE LD_VERSION)