Changeset 183758 in webkit

Timestamp:

May 4, 2015 12:22:38 PM (9 years ago)

Author:

rniwa@webkit.org

Message:

ES6 classes: Invalid test for constructor property
​https://bugs.webkit.org/show_bug.cgi?id=144278

Reviewed by Darin Adler.

Fixed the test. The constructors of two distinct classes should definitely be distinct.

• js/class-syntax-default-constructor-expected.txt:
• js/script-tests/class-syntax-default-constructor.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• js/class-syntax-default-constructor-expected.txt (modified) (1 diff)
• js/script-tests/class-syntax-default-constructor.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-05-04  Ryosuke Niwa  <rniwa@webkit.org>
+
+        ES6 classes: Invalid test for constructor property
+        https://bugs.webkit.org/show_bug.cgi?id=144278
+
+        Reviewed by Darin Adler.
+
+        Fixed the test. The constructors of two distinct classes should definitely be distinct.
+
+        * js/class-syntax-default-constructor-expected.txt:
+        * js/script-tests/class-syntax-default-constructor.js:
+
 2015-05-04  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/js/class-syntax-default-constructor-expected.txt

@@ -12 +12 @@
 PASS B.prototype.constructor.name is "B"
 PASS A !== B is true
-FAIL A.prototype.constructor should be function B() { super(...arguments); }. Was function A() { }.
+PASS A.prototype.constructor is not B.prototype.constructor
 PASS new (class extends (class { constructor(a, b) { return [a, b]; } }) {})(1, 2) is [1, 2]
 PASS successfullyParsed is true

trunk/LayoutTests/js/script-tests/class-syntax-default-constructor.js

@@ -13 +13 @@
 shouldBe('B.prototype.constructor.name', '"B"');
 shouldBeTrue('A !== B');
-shouldBe('A.prototype.constructor', 'B.prototype.constructor');
+shouldNotBe('A.prototype.constructor', 'B.prototype.constructor');
 shouldBe('new (class extends (class { constructor(a, b) { return [a, b]; } }) {})(1, 2)', '[1, 2]');