Changeset 183894 in webkit
- Timestamp:
- May 6, 2015 3:46:01 PM (9 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r183878 r183894 1 2015-05-06 Dean Jackson <dino@apple.com> 2 3 Handle backdrop views that have to tile 4 https://bugs.webkit.org/show_bug.cgi?id=142317 5 <rdar://problem/20049088> 6 7 Reviewed by Simon Fraser. 8 9 A test that creates some backdrop views, then makes them 10 big enough that it would trigger tiling (which we don't want 11 to happen). 12 13 * compositing/media-controls-bar-appearance-big-expected.txt: Added. 14 * compositing/media-controls-bar-appearance-big.html: Added. 15 1 16 2015-05-06 Martin Robinson <mrobinson@igalia.com> 2 17 -
trunk/Source/WebCore/ChangeLog
r183892 r183894 1 2015-05-06 Dean Jackson <dino@apple.com> 2 3 Handle backdrop views that have to tile 4 https://bugs.webkit.org/show_bug.cgi?id=142317 5 <rdar://problem/20049088> 6 7 Reviewed by Simon Fraser. 8 9 Make sure backdrop layers don't tile. If they are big 10 enough, we'll leave it to the platform compositor to handle. 11 12 This also fixes a bug where if a layer changed from a backdrop 13 type to a tiled type, it would still retain its custom appearance 14 and we'd try to add children to the wrong layer. 15 16 Test: compositing/media-controls-bar-appearance-big.html 17 18 * platform/graphics/ca/GraphicsLayerCA.cpp: 19 (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Check if 20 a layer needs a backdrop before checking if it needs to tile. 21 1 22 2015-05-06 Carlos Garcia Campos <cgarcia@igalia.com> and Per Arne Vollan <peavo@outlook.com> 2 23 -
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
r183354 r183894 1439 1439 PlatformCALayer::LayerType neededLayerType = m_layer->layerType(); 1440 1440 1441 if (needTiledLayer) 1441 if (needBackdropLayerType) 1442 neededLayerType = layerTypeForCustomBackdropAppearance(customAppearance()); 1443 else if (needTiledLayer) 1442 1444 neededLayerType = PlatformCALayer::LayerTypeTiledBackingLayer; 1443 else if (needBackdropLayerType)1444 neededLayerType = layerTypeForCustomBackdropAppearance(customAppearance());1445 1445 else if (isCustomBackdropLayerType(m_layer->layerType()) || m_usingTiledBacking) 1446 1446 neededLayerType = PlatformCALayer::LayerTypeWebLayer; -
trunk/Source/WebKit2/ChangeLog
r183893 r183894 1 2015-05-06 Dean Jackson <dino@apple.com> 2 3 Handle backdrop views that have to tile 4 https://bugs.webkit.org/show_bug.cgi?id=142317 5 <rdar://problem/20049088> 6 7 Reviewed by Simon Fraser. 8 9 Add some better logging for custom appearance. 10 11 * Shared/mac/RemoteLayerTreeTransaction.mm: 12 (WebKit::RemoteLayerTreeTextStream::operator<<): 13 1 14 2015-05-06 Chris Dumez <cdumez@apple.com> 2 15 -
trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm
r183242 r183894 667 667 RemoteLayerTreeTextStream& operator<<(const PlatformCAAnimationRemote::Properties&); 668 668 RemoteLayerTreeTextStream& operator<<(const RemoteLayerBackingStore&); 669 RemoteLayerTreeTextStream& operator<<(const WebCore::GraphicsLayer::CustomAppearance&); 669 670 RemoteLayerTreeTextStream& operator<<(BlendMode); 670 671 RemoteLayerTreeTextStream& operator<<(PlatformCAAnimation::AnimationType); … … 834 835 ts << "none"; 835 836 break; 837 } 838 return ts; 839 } 840 841 RemoteLayerTreeTextStream& RemoteLayerTreeTextStream::operator<<(const WebCore::GraphicsLayer::CustomAppearance& customAppearance) 842 { 843 RemoteLayerTreeTextStream& ts = *this; 844 switch (customAppearance) { 845 case WebCore::GraphicsLayer::CustomAppearance::NoCustomAppearance: ts << "none"; break; 846 case WebCore::GraphicsLayer::CustomAppearance::ScrollingOverhang: ts << "scrolling-overhang"; break; 847 case WebCore::GraphicsLayer::CustomAppearance::ScrollingShadow: ts << "scrolling-shadow"; break; 848 case WebCore::GraphicsLayer::CustomAppearance::LightBackdropAppearance: ts << "light-backdrop"; break; 849 case WebCore::GraphicsLayer::CustomAppearance::DarkBackdropAppearance: ts << "dark-backdrop"; break; 836 850 } 837 851 return ts;
Note: See TracChangeset
for help on using the changeset viewer.