Changeset 184108 in webkit
- Timestamp:
- May 11, 2015, 10:50:25 AM (10 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
TabularUnified trunk/Source/WebInspectorUI/ChangeLog ¶
r184045 r184108 1 2015-05-11 Timothy Hatcher <timothy@apple.com> 2 3 Web Inspector: NavigationSidebarPanel leaks some event listeners 4 https://bugs.webkit.org/show_bug.cgi?id=144523 5 6 Reviewed by Joseph Pecoraro. 7 8 * UserInterface/Views/NavigationSidebarPanel.js: 9 (WebInspector.NavigationSidebarPanel): 10 (WebInspector.NavigationSidebarPanel.prototype.closed): 11 * UserInterface/Views/ResourceSidebarPanel.js: 12 (WebInspector.ResourceSidebarPanel.prototype.closed): 13 * UserInterface/Views/SearchSidebarPanel.js: 14 (WebInspector.SearchSidebarPanel.prototype.closed): 15 * UserInterface/Views/StorageSidebarPanel.js: 16 (WebInspector.StorageSidebarPanel.prototype.closed): 17 * UserInterface/Views/TimelineSidebarPanel.js: 18 (WebInspector.TimelineSidebarPanel.prototype.closed): 19 1 20 2015-05-10 Nikita Vasilyev <nvasilyev@apple.com> 2 21 -
TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js ¶
r183821 r184108 53 53 } 54 54 55 window.addEventListener("resize", this._updateContentOverflowShadowVisibility.bind(this)); 55 this._boundUpdateContentOverflowShadowVisibility = this._updateContentOverflowShadowVisibility.bind(this); 56 window.addEventListener("resize", this._boundUpdateContentOverflowShadowVisibility); 56 57 57 58 this._filtersSetting = new WebInspector.Setting(identifier + "-navigation-sidebar-filters", {}); … … 76 77 77 78 // Public 79 80 closed() 81 { 82 window.removeEventListener("resize", this._boundUpdateContentOverflowShadowVisibility); 83 WebInspector.Frame.removeEventListener(null, null, this); 84 } 78 85 79 86 get contentBrowser() -
TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js ¶
r183714 r184108 57 57 closed() 58 58 { 59 super.closed(); 60 59 61 WebInspector.Frame.removeEventListener(null, null, this); 60 62 WebInspector.frameResourceManager.removeEventListener(null, null, this); -
TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js ¶
r183339 r184108 65 65 closed() 66 66 { 67 super.closed(); 68 67 69 WebInspector.Frame.removeEventListener(null, null, this); 68 70 } -
TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js ¶
r183580 r184108 86 86 closed() 87 87 { 88 super.closed(); 89 88 90 WebInspector.storageManager.removeEventListener(null, null, this); 89 91 WebInspector.applicationCacheManager.removeEventListener(null, null, this); -
TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js ¶
r183821 r184108 173 173 closed() 174 174 { 175 super.closed(); 176 175 177 WebInspector.showReplayInterfaceSetting.removeEventListener(null, null, this); 176 178 WebInspector.replayManager.removeEventListener(null, null, this);
Note:
See TracChangeset
for help on using the changeset viewer.