Changeset 184108 in webkit


Ignore:
Timestamp:
May 11, 2015, 10:50:25 AM (10 years ago)
Author:
timothy@apple.com
Message:

Web Inspector: NavigationSidebarPanel leaks some event listeners
https://bugs.webkit.org/show_bug.cgi?id=144523

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype.closed):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.closed):

  • UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype.closed):

  • UserInterface/Views/StorageSidebarPanel.js:

(WebInspector.StorageSidebarPanel.prototype.closed):

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.closed):

Location:
trunk/Source/WebInspectorUI
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • TabularUnified trunk/Source/WebInspectorUI/ChangeLog

    r184045 r184108  
     12015-05-11  Timothy Hatcher  <timothy@apple.com>
     2
     3        Web Inspector: NavigationSidebarPanel leaks some event listeners
     4        https://bugs.webkit.org/show_bug.cgi?id=144523
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * UserInterface/Views/NavigationSidebarPanel.js:
     9        (WebInspector.NavigationSidebarPanel):
     10        (WebInspector.NavigationSidebarPanel.prototype.closed):
     11        * UserInterface/Views/ResourceSidebarPanel.js:
     12        (WebInspector.ResourceSidebarPanel.prototype.closed):
     13        * UserInterface/Views/SearchSidebarPanel.js:
     14        (WebInspector.SearchSidebarPanel.prototype.closed):
     15        * UserInterface/Views/StorageSidebarPanel.js:
     16        (WebInspector.StorageSidebarPanel.prototype.closed):
     17        * UserInterface/Views/TimelineSidebarPanel.js:
     18        (WebInspector.TimelineSidebarPanel.prototype.closed):
     19
    1202015-05-10  Nikita Vasilyev  <nvasilyev@apple.com>
    221
  • TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js

    r183821 r184108  
    5353        }
    5454
    55         window.addEventListener("resize", this._updateContentOverflowShadowVisibility.bind(this));
     55        this._boundUpdateContentOverflowShadowVisibility = this._updateContentOverflowShadowVisibility.bind(this);
     56        window.addEventListener("resize", this._boundUpdateContentOverflowShadowVisibility);
    5657
    5758        this._filtersSetting = new WebInspector.Setting(identifier + "-navigation-sidebar-filters", {});
     
    7677
    7778    // Public
     79
     80    closed()
     81    {
     82        window.removeEventListener("resize", this._boundUpdateContentOverflowShadowVisibility);
     83        WebInspector.Frame.removeEventListener(null, null, this);
     84    }
    7885
    7986    get contentBrowser()
  • TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

    r183714 r184108  
    5757    closed()
    5858    {
     59        super.closed();
     60
    5961        WebInspector.Frame.removeEventListener(null, null, this);
    6062        WebInspector.frameResourceManager.removeEventListener(null, null, this);
  • TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js

    r183339 r184108  
    6565    closed()
    6666    {
     67        super.closed();
     68
    6769        WebInspector.Frame.removeEventListener(null, null, this);
    6870    }
  • TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js

    r183580 r184108  
    8686    closed()
    8787    {
     88        super.closed();
     89
    8890        WebInspector.storageManager.removeEventListener(null, null, this);
    8991        WebInspector.applicationCacheManager.removeEventListener(null, null, this);
  • TabularUnified trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js

    r183821 r184108  
    173173    closed()
    174174    {
     175        super.closed();
     176
    175177        WebInspector.showReplayInterfaceSetting.removeEventListener(null, null, this);
    176178        WebInspector.replayManager.removeEventListener(null, null, this);
Note: See TracChangeset for help on using the changeset viewer.