Changeset 18443 in webkit

Timestamp:

Dec 27, 2006 3:43:41 PM (17 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Hyatt.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=11452 REGRESSION (r16736-r16801): Incorrect repaint of fixed boxes

• fast/repaint/fixed-expected.checksum: Added.
• fast/repaint/fixed-expected.png: Added.
• fast/repaint/fixed-expected.txt: Added.
• fast/repaint/fixed.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11452 REGRESSION (r16736-r16801): Incorrect repaint of fixed boxes

Test: fast/repaint/fixed.html

• rendering/RenderView.cpp: (WebCore::RenderView::computeAbsoluteRepaintRect): Re-added.
• rendering/RenderView.h:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/fixed-expected.checksum (added)
• LayoutTests/fast/repaint/fixed-expected.png (added)
• LayoutTests/fast/repaint/fixed-expected.txt (added)
• LayoutTests/fast/repaint/fixed.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderView.cpp (modified) (1 diff)
• WebCore/rendering/RenderView.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2006-12-27  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Hyatt.
+
+        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=11452
+          REGRESSION (r16736-r16801): Incorrect repaint of fixed boxes
+
+        * fast/repaint/fixed-expected.checksum: Added.
+        * fast/repaint/fixed-expected.png: Added.
+        * fast/repaint/fixed-expected.txt: Added.
+        * fast/repaint/fixed.html: Added.
+
 2006-12-27  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-12-27  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=11452
+          REGRESSION (r16736-r16801): Incorrect repaint of fixed boxes
+
+        Test: fast/repaint/fixed.html
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::computeAbsoluteRepaintRect): Re-added.
+        * rendering/RenderView.h:
+
 2006-12-27  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/rendering/RenderView.cpp

@@ -206 +206 @@
 }
 
+void RenderView::computeAbsoluteRepaintRect(IntRect& rect, bool fixed)
+{
+    if (m_printingMode)
+        return;
+
+    if (fixed && m_frameView)
+        rect.move(m_frameView->contentsX(), m_frameView->contentsY());
+}
+
 void RenderView::absoluteRects(Vector<IntRect>& rects, int tx, int ty)
 {

trunk/WebCore/rendering/RenderView.h

@@ -53 +53 @@
     virtual bool hasOverhangingFloats() { return false; }
 
+    virtual void computeAbsoluteRepaintRect(IntRect&, bool fixed = false);
     virtual void repaintViewRectangle(const IntRect&, bool immediate = false);