Changeset 18457 in webkit


Ignore:
Timestamp:
Dec 28, 2006 11:53:58 AM (17 years ago)
Author:
weinig
Message:

LayoutTests:

Reviewed by Darin.

  • fast/text/atsui-partial-selection-expected.checksum: Added.
  • fast/text/atsui-partial-selection-expected.png: Added.
  • fast/text/atsui-partial-selection-expected.txt: Added.
  • fast/text/atsui-partial-selection.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/text/atsui-partial-selection.html

  • platform/Font.h: Changed comment.
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): Corrected the run length calculation. Changed the ATSUI layout parameters to know about the entire text run, rather than just the range we are drawing. ATSUI measures the characters before the range and positions the range accordingly.
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r18456 r18457  
     12006-12-28  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Darin.
     4
     5        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=11124
     6          REGRESSION (r14297): No drag image for partially-selected complex text
     7
     8        * fast/text/atsui-partial-selection-expected.checksum: Added.
     9        * fast/text/atsui-partial-selection-expected.png: Added.
     10        * fast/text/atsui-partial-selection-expected.txt: Added.
     11        * fast/text/atsui-partial-selection.html: Added.
     12
    1132006-12-28  Mitz Pettel  <mitz@webkit.org>
    214

  • trunk/WebCore/ChangeLog

    r18456 r18457  
     12006-12-28  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Darin.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=11124
     6          REGRESSION (r14297): No drag image for partially-selected complex text
     7
     8        Test: fast/text/atsui-partial-selection.html
     9
     10        * platform/Font.h: Changed comment.
     11        * platform/mac/FontMac.mm:
     12        (WebCore::Font::drawComplexText): Corrected the run length calculation.
     13        Changed the ATSUI layout parameters to know about the entire text run, rather
     14        than just the range we are drawing. ATSUI measures the characters before
     15        the range and positions the range accordingly.
     16
    1172006-12-28  Mitz Pettel  <mitz@webkit.org>
    218

  • trunk/WebCore/platform/Font.h

    r16594 r18457  
    5151    {}
    5252
    53     TextRun(const UChar* c, int len, int from, int to) // This constructor is only used in one place in Mac-specific code.
     53    TextRun(const UChar* c, int len, int from, int to) // This constructor is only used in Mac-specific code.
    5454    :m_characters(c), m_len(len), m_from(from), m_to(to)
    5555    {}

  • trunk/WebCore/platform/mac/FontMac.mm

    r18360 r18457  
    474474    OSStatus status;
    475475   
    476     int runLength = run.length();
     476    int runLength = run.to() - run.from();
    477477
    478478    TextRun adjustedRun = style.directionalOverride() ? addDirectionalOverride(run, style.rtl()) : run;
    479     ATSULayoutParameters params(adjustedRun, style);
     479    ATSULayoutParameters params(TextRun(adjustedRun.characters(), adjustedRun.length(), 0, adjustedRun.length()), style);
    480480    params.initialize(this, graphicsContext);
    481481   
Note: See TracChangeset for help on using the changeset viewer.