Changeset 184807 in webkit

Timestamp:

May 22, 2015, 5:26:54 PM (10 years ago)

Author:

ap@apple.com

Message:

REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
​https://bugs.webkit.org/show_bug.cgi?id=130463
rdar://problem/20461342

Reviewed by Tim Horton.

This was more of a timing related flakiness than an actual OS version specific bug,
we weren't getting window visibility notifications.

I will look into adding this function call to DumpRenderTree separately, layout tests
might actually rely on the broken behavior.

• TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::TEST_F):

• TestWebKitAPI/mac/mainMac.mm:

(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm (modified) (2 diffs)
• TestWebKitAPI/mac/mainMac.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-05-22  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
+        https://bugs.webkit.org/show_bug.cgi?id=130463
+        rdar://problem/20461342
+
+        Reviewed by Tim Horton.
+
+        This was more of a timing related flakiness than an actual OS version specific bug,
+        we weren't getting window visibility notifications.
+        
+        I will look into adding this function call to DumpRenderTree separately, layout tests
+        might actually rely on the broken behavior.
+
+        * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
+        (TestWebKitAPI::TEST_F):
+        * TestWebKitAPI/mac/mainMac.mm:
+        (main):
+
 2015-05-22  Dana Burkart  <dburkart@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm

@@ -31 +31 @@
 #import <WebKit/WKViewPrivate.h>
 #import <wtf/RetainPtr.h>
-
-// https://bugs.webkit.org/show_bug.cgi?id=130463
-// rdar://problem/20461342
-#if __MAC_OS_X_VERSION_MIN_REQUIRED == 101000
 
 static bool isWaitingForPageSignalToContinue = false;
@@ -181 +177 @@
 
 } // namespace TestWebKitAPI
-
-#endif

trunk/Tools/TestWebKitAPI/mac/mainMac.mm

@@ -27 +27 @@
 #import "TestsController.h"
 
+extern "C" void _BeginEventReceiptOnThread(void);
+
 int main(int argc, char** argv)
 {
@@ -32 +34 @@
 
     [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"TestWebKitAPI"];
+
     [NSApplication sharedApplication];
+    _BeginEventReceiptOnThread(); // Makes window visibility notifications work (and possibly more).
 
     bool passed = TestWebKitAPI::TestsController::singleton().run(argc, argv);