Changeset 184955 in webkit


Ignore:
Timestamp:
May 28, 2015 5:16:45 AM (9 years ago)
Author:
youenn.fablet@crf.canon.fr
Message:

[Streams API] ReadableStreamReader should not be exposed
​https://bugs.webkit.org/show_bug.cgi?id=143564

Reviewed by Darin Adler.

Source/WebCore:

Covered by rebased tests.

  • Modules/streams/ReadableStreamReader.idl: Adding NoInterfaceObject to ReadableStreamReader.idl.

LayoutTests:

Rebasing tests as ReadableStreamReader is no longer defined globally.

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r184943 r184955  
     12015-05-28  Xabier Rodriguez Calvar  <calvaris@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
     2
     3        [Streams API] ReadableStreamReader should not be exposed
     4        https://bugs.webkit.org/show_bug.cgi?id=143564
     5
     6        Reviewed by Darin Adler.
     7
     8        Rebasing tests as ReadableStreamReader is no longer defined globally.
     9
     10        * js/dom/global-constructors-attributes-expected.txt:
     11        * platform/efl/js/dom/global-constructors-attributes-expected.txt:
     12        * platform/gtk/js/dom/global-constructors-attributes-expected.txt:
     13        * platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
     14        * platform/mac/js/dom/global-constructors-attributes-expected.txt:
     15        * platform/win/js/dom/global-constructors-attributes-expected.txt:
     16
    1172015-05-27  Alexey Proskuryakov  <ap@apple.com>
    218

  • trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt

    r182180 r184955  
    999999PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    10001000PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    1001 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').value is ReadableStreamReader
    1002 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('get') is false
    1003 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('set') is false
    1004 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').enumerable is false
    1005 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').configurable is true
    10061001PASS Object.getOwnPropertyDescriptor(global, 'Rect').value is Rect
    10071002PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('get') is false

  • trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt

    r182180 r184955  
    999999PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    10001000PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    1001 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').value is ReadableStreamReader
    1002 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('get') is false
    1003 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('set') is false
    1004 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').enumerable is false
    1005 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').configurable is true
    10061001PASS Object.getOwnPropertyDescriptor(global, 'Rect').value is Rect
    10071002PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('get') is false

  • trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt

    r182180 r184955  
    10741074PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    10751075PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    1076 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').value is ReadableStreamReader
    1077 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('get') is false
    1078 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('set') is false
    1079 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').enumerable is false
    1080 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').configurable is true
    10811076PASS Object.getOwnPropertyDescriptor(global, 'Rect').value is Rect
    10821077PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('get') is false

  • trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt

    r182748 r184955  
    10091009PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    10101010PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    1011 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').value is ReadableStreamReader
    1012 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('get') is false
    1013 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('set') is false
    1014 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').enumerable is false
    1015 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').configurable is true
    10161011PASS Object.getOwnPropertyDescriptor(global, 'Rect').value is Rect
    10171012PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('get') is false

  • trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt

    r182748 r184955  
    10291029PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    10301030PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    1031 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').value is ReadableStreamReader
    1032 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('get') is false
    1033 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('set') is false
    1034 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').enumerable is false
    1035 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').configurable is true
    10361031PASS Object.getOwnPropertyDescriptor(global, 'Rect').value is Rect
    10371032PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('get') is false

  • trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt

    r183493 r184955  
    849849PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').enumerable is false
    850850PASS Object.getOwnPropertyDescriptor(global, 'ReadableStream').configurable is true
    851 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').value is ReadableStreamReader
    852 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('get') is false
    853 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').hasOwnProperty('set') is false
    854 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').enumerable is false
    855 PASS Object.getOwnPropertyDescriptor(global, 'ReadableStreamReader').configurable is true
    856851PASS Object.getOwnPropertyDescriptor(global, 'Rect').value is Rect
    857852PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('get') is false

  • trunk/Source/WebCore/ChangeLog

    r184954 r184955  
     12015-05-28  Xabier Rodriguez Calvar  <calvaris@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
     2
     3        [Streams API] ReadableStreamReader should not be exposed
     4        https://bugs.webkit.org/show_bug.cgi?id=143564
     5
     6        Reviewed by Darin Adler.
     7
     8        Covered by rebased tests.
     9
     10        * Modules/streams/ReadableStreamReader.idl: Adding NoInterfaceObject to ReadableStreamReader.idl.
     11
    1122015-05-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
    213

  • trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl

    r184444 r184955  
    2929
    3030[
     31    Conditional=STREAMS_API,
    3132    CustomConstructor(any properties),
    32     Conditional=STREAMS_API,
     33    NoInterfaceObject,
    3334    SkipVTableValidation
    3435] interface ReadableStreamReader {
Note: See TracChangeset for help on using the changeset viewer.