Changeset 185220 in webkit

Timestamp:

Jun 4, 2015, 3:08:59 PM (10 years ago)

Author:

eric.carlson@apple.com

Message:

[Mac] Don't show default controls after playing to wireless target, again
​https://bugs.webkit.org/show_bug.cgi?id=145620
<rdar://problem/21145806>

Reviewed by Dean Jackson.

Follow up to fix two tests broken by r185207.

• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updateControls): Always show controls when the video element

is the fullscreen element because custom controls aren't possible.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediacontrols/mediaControlsApple.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog ¶

@@ +1 @@
+2015-06-04  Eric Carlson  <eric.carlson@apple.com>
+
+        [Mac] Don't show default controls after playing to wireless target, again
+        https://bugs.webkit.org/show_bug.cgi?id=145620
+        <rdar://problem/21145806>
+
+        Reviewed by Dean Jackson.
+
+        Follow up to fix two tests broken by r185207.
+
+        * Modules/mediacontrols/mediaControlsApple.js:
+        (Controller.prototype.updateControls): Always show controls when the video element
+          is the fullscreen element because custom controls aren't possible.
+
 2015-06-04  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js ¶

@@ -613 +613 @@
         this.setNeedsTimelineMetricsUpdate();
 
-        if (this.video.controls) {
+        if (this.video.controls || this.isFullScreen()) {
             this.controls.panel.classList.add(this.ClassNames.show);
             this.controls.panel.classList.remove(this.ClassNames.hidden);