Changeset 185576 in webkit

Timestamp:

Jun 15, 2015 7:10:58 PM (9 years ago)

Author:

Simon Fraser

Message:

[iOS WK2] position:fixed elements sometimes truncated on scroll view bouncing
​https://bugs.webkit.org/show_bug.cgi?id=146000
rdar://problem/19448439

Reviewed by Benjamin Poulain.

When in the middle of a rubber-band (UIScrollView bounce), we could send a bad
fixed position rect down to WebCore, causing 100% height elements to get laid out
at the wrong height, possible too short. This occurred when -_updateVisibleContentRects
said we were in a stable state, but the rubber-band offset caused WebPageProxy::computeCustomFixedPositionRect()
to compute a bad rect via constrainedUnobscuredRect.intersect(documentRect).

Fix by not claiming to be in a stable state during rubber-banding. Added _scrollViewIsRubberBanding
to compute that, taking care with floating point comparisons for 3x devices.

• UIProcess/API/Cocoa/WKWebView.mm:

(isGreaterInDevicePixels):
(-[WKWebView _scrollViewIsRubberBanding]):
(-[WKWebView _updateVisibleContentRects]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-06-15  Simon Fraser  <simon.fraser@apple.com>
+
+        [iOS WK2] position:fixed elements sometimes truncated on scroll view bouncing
+        https://bugs.webkit.org/show_bug.cgi?id=146000
+        rdar://problem/19448439
+
+        Reviewed by Benjamin Poulain.
+        
+        When in the middle of a rubber-band (UIScrollView bounce), we could send a bad 
+        fixed position rect down to WebCore, causing 100% height elements to get laid out
+        at the wrong height, possible too short. This occurred when -_updateVisibleContentRects
+        said we were in a stable state, but the rubber-band offset caused WebPageProxy::computeCustomFixedPositionRect()
+        to compute a bad rect via constrainedUnobscuredRect.intersect(documentRect).
+        
+        Fix by not claiming to be in a stable state during rubber-banding. Added _scrollViewIsRubberBanding
+        to compute that, taking care with floating point comparisons for 3x devices.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (isGreaterInDevicePixels):
+        (-[WKWebView _scrollViewIsRubberBanding]):
+        (-[WKWebView _updateVisibleContentRects]):
+
 2015-06-15  Ryuan Choi  <ryuan.choi@navercorp.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

@@ -690 +690 @@
 }
 
+static inline bool pointsEqualInDevicePixels(CGPoint a, CGPoint b, float deviceScaleFactor)
+{
+    return fabs(a.x * deviceScaleFactor - b.x * deviceScaleFactor) < std::numeric_limits<float>::epsilon()
+        && fabs(a.y * deviceScaleFactor - b.y * deviceScaleFactor) < std::numeric_limits<float>::epsilon();
+}
+
 static CGSize roundScrollViewContentSize(const WebKit::WebPageProxy& page, CGSize contentSize)
 {
@@ -1514 +1520 @@
 }
 
+// Ideally UIScrollView would expose this for us: <rdar://problem/21394567>.
+- (BOOL)_scrollViewIsRubberBanding
+{
+    float deviceScaleFactor = _page->deviceScaleFactor();
+
+    CGPoint contentOffset = [_scrollView contentOffset];
+    CGPoint boundedOffset = contentOffsetBoundedInValidRange(_scrollView.get(), contentOffset);
+    return !pointsEqualInDevicePixels(contentOffset, boundedOffset, deviceScaleFactor);
+}
+
 - (void)_updateVisibleContentRects
 {
@@ -1540 +1556 @@
     CGFloat scaleFactor = contentZoomScale(self);
 
-    BOOL isStableState = !(_isChangingObscuredInsetsInteractively || [_scrollView isDragging] || [_scrollView isDecelerating] || [_scrollView isZooming] || [_scrollView isZoomBouncing] || [_scrollView _isAnimatingZoom] || [_scrollView _isScrollingToTop]);
+    BOOL isStableState = !(_isChangingObscuredInsetsInteractively || [_scrollView isDragging] || [_scrollView isDecelerating] || [_scrollView isZooming] || [_scrollView isZoomBouncing] || [_scrollView _isAnimatingZoom] || [_scrollView _isScrollingToTop] || [self _scrollViewIsRubberBanding]);
 
     // FIXME: this can be made static after we stop supporting iOS 8.x.