Changeset 185666 in webkit

Timestamp:

Jun 17, 2015 2:08:44 PM (9 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r173283-r173296): Amazon.com front page has no caret in the search field
​https://bugs.webkit.org/show_bug.cgi?id=146073
rdar://problem/21022203

Reviewed by Tim Horton.

Source/WebCore:

Text controls (text inputs and textareas) need backing store even when empty, because
they need to be able to paint a caret.

Test: compositing/backing/form-controls-backing.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

LayoutTests:

Dump layers for composited text inputs and textareas.

• compositing/backing/form-controls-backing-expected.txt: Added.
• compositing/backing/form-controls-backing.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/backing/form-controls-backing-expected.txt (added)
• LayoutTests/compositing/backing/form-controls-backing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-06-17  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r173283-r173296): Amazon.com front page has no caret in the search field
+        https://bugs.webkit.org/show_bug.cgi?id=146073
+        rdar://problem/21022203
+
+        Reviewed by Tim Horton.
+
+        Dump layers for composited text inputs and textareas.
+
+        * compositing/backing/form-controls-backing-expected.txt: Added.
+        * compositing/backing/form-controls-backing.html: Added.
+
 2015-06-17  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-17  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r173283-r173296): Amazon.com front page has no caret in the search field
+        https://bugs.webkit.org/show_bug.cgi?id=146073
+        rdar://problem/21022203
+
+        Reviewed by Tim Horton.
+
+        Text controls (text inputs and textareas) need backing store even when empty, because
+        they need to be able to paint a caret.
+
+        Test: compositing/backing/form-controls-backing.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
+
 2015-06-17  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -1849 +1849 @@
         return false;
 
+    if (renderer().isTextControl())
+        return false;
+
     if (paintsBoxDecorations() || paintsChildren())
         return false;