Changeset 185858 in webkit

Timestamp:

Jun 22, 2015, 6:59:08 PM (11 years ago)

Author:

Simon Fraser

Message:

ASSERT(!m_zOrderListsDirty) when mousing over web view with incremental rendering suppressed
​https://bugs.webkit.org/show_bug.cgi?id=146225

Reviewed by Zalan Bujtas.

Update RenderLayer's z-order lists when hit testing. There's no guarantee that they've
been updated; this happens to work most of the time because painting updates them,
but if incremental rendering is suppressed, we may not have painted yet.

Easy to hit on webkit.org in MiniBrowser, but I wasn't able to make a reduced testcase.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::updateLayerListsIfNeeded): Flip the order of the tests, since checking
dirty bits is cheaper than calling isStackingContext().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-22  Simon Fraser  <simon.fraser@apple.com>
+
+        ASSERT(!m_zOrderListsDirty) when mousing over web view with incremental rendering suppressed
+        https://bugs.webkit.org/show_bug.cgi?id=146225
+
+        Reviewed by Zalan Bujtas.
+
+        Update RenderLayer's z-order lists when hit testing. There's no guarantee that they've
+        been updated; this happens to work most of the time because painting updates them,
+        but if incremental rendering is suppressed, we may not have painted yet.
+        
+        Easy to hit on webkit.org in MiniBrowser, but I wasn't able to make a reduced testcase.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::hitTest):
+        (WebCore::RenderLayer::updateLayerListsIfNeeded): Flip the order of the tests, since checking
+        dirty bits is cheaper than calling isStackingContext().
+
 2015-06-22  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -4809 +4809 @@
     ASSERT(isSelfPaintingLayer() || hasSelfPaintingLayerDescendant());
     ASSERT(!renderer().view().needsLayout());
+    
+    updateLayerListsIfNeeded();
 
     LayoutRect hitTestArea = isOutOfFlowRenderFlowThread() ? downcast<RenderFlowThread>(renderer()).visualOverflowRect() : renderer().view().documentRect();
@@ -6304 +6306 @@
 void RenderLayer::updateLayerListsIfNeeded()
 {
-    bool shouldUpdateDescendantsAreContiguousInStackingOrder = isStackingContext() && (m_zOrderListsDirty || m_normalFlowListDirty);
+    bool shouldUpdateDescendantsAreContiguousInStackingOrder = (m_zOrderListsDirty || m_normalFlowListDirty) && isStackingContext();
     updateZOrderLists();
     updateNormalFlowList();