Changeset 186390 in webkit

Timestamp:

Jul 6, 2015, 6:11:49 PM (10 years ago)

Author:

Simon Fraser

Message:

Revert use of SVG <mask> elements for -webkit-mask-image (r176798, r177494, r186180)
​https://bugs.webkit.org/show_bug.cgi?id=146653

Fixes rdar://problem/21435233.

This patch reverts r186180, but keeps the layout test.

This feature caused a number of regressions (bugs 141857, 146509, 146561), added new layering violations, and
was not being maintained, so revert it.

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource): Deleted.

• loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::acceptOverride): Deleted.
(WebCore::CachedResourceRequest::setAcceptOverride): Deleted.

• loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::load): Deleted.

• loader/cache/CachedSVGDocumentReference.h:

(WebCore::CachedSVGDocumentReference::setAcceptsAnyImageType): Deleted.

• platform/graphics/MaskImageOperation.cpp:

(WebCore::MaskImageOperation::ensureCachedSVGDocumentReference):
(WebCore::MaskImageOperation::notifyFinished):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/cache/CachedResourceLoader.cpp (modified) (1 diff)
• loader/cache/CachedResourceRequest.h (modified) (3 diffs)
• loader/cache/CachedSVGDocumentReference.cpp (modified) (1 diff)
• loader/cache/CachedSVGDocumentReference.h (modified) (2 diffs)
• platform/graphics/MaskImageOperation.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-07-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Revert use of SVG <mask> elements for -webkit-mask-image (r176798, r177494, r186180)
+        https://bugs.webkit.org/show_bug.cgi?id=146653
+        
+        Fixes rdar://problem/21435233.
+
+        This patch reverts r186180, but keeps the layout test.
+
+        This feature caused a number of regressions (bugs 141857, 146509, 146561), added new layering violations, and
+        was not being maintained, so revert it.
+        
+        * loader/cache/CachedResourceLoader.cpp:
+        (WebCore::CachedResourceLoader::requestResource): Deleted.
+        * loader/cache/CachedResourceRequest.h:
+        (WebCore::CachedResourceRequest::acceptOverride): Deleted.
+        (WebCore::CachedResourceRequest::setAcceptOverride): Deleted.
+        * loader/cache/CachedSVGDocumentReference.cpp:
+        (WebCore::CachedSVGDocumentReference::load): Deleted.
+        * loader/cache/CachedSVGDocumentReference.h:
+        (WebCore::CachedSVGDocumentReference::setAcceptsAnyImageType): Deleted.
+        * platform/graphics/MaskImageOperation.cpp:
+        (WebCore::MaskImageOperation::ensureCachedSVGDocumentReference):
+        (WebCore::MaskImageOperation::notifyFinished):
+
 2015-07-06  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp

@@ -565 +565 @@
 
     if ((policy != Use || resource->stillNeedsLoad()) && CachedResourceRequest::NoDefer == request.defer()) {
-        if (request.acceptOverride())
-            resource->setAccept(request.acceptOverride().value());
-
         resource->load(*this, request.options());
 

trunk/Source/WebCore/loader/cache/CachedResourceRequest.h

@@ -54 +54 @@
     void setOptions(const ResourceLoaderOptions& options) { m_options = options; }
     const Optional<ResourceLoadPriority>& priority() const { return m_priority; }
-    const Optional<String>& acceptOverride() const { return m_acceptOverride; }
     bool forPreload() const { return m_forPreload; }
     void setForPreload(bool forPreload) { m_forPreload = forPreload; }
@@ -61 +60 @@
     void setInitiator(PassRefPtr<Element>);
     void setInitiator(const AtomicString& name);
-    void setAcceptOverride(const String& accept) { m_acceptOverride = accept; }
     const AtomicString& initiatorName() const;
 
@@ -72 +70 @@
     ResourceLoaderOptions m_options;
     Optional<ResourceLoadPriority> m_priority;
-    Optional<String> m_acceptOverride;
     bool m_forPreload;
     DeferOption m_defer;

trunk/Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp

@@ -61 +61 @@
     CachedResourceRequest request(ResourceRequest(loader.document()->completeURL(m_url)), options);
     request.setInitiator(cachedResourceRequestInitiators().css);
-    if (m_acceptsAnyImageType)
-        request.setAcceptOverride("image/*");
     m_document = loader.requestSVGDocument(request);
     if (m_document) {

trunk/Source/WebCore/loader/cache/CachedSVGDocumentReference.h

@@ -45 +45 @@
     void load(CachedResourceLoader&, const ResourceLoaderOptions&);
     bool loadRequested() const { return m_loadRequested; }
-    void setAcceptsAnyImageType() { m_acceptsAnyImageType = true; }
 
     CachedSVGDocument* document() { return m_document.get(); }
@@ -55 +54 @@
     CachedSVGDocumentClient* m_additionalDocumentClient;
     bool m_canReuseResource;
-    bool m_acceptsAnyImageType { false };
 };
 

trunk/Source/WebCore/platform/graphics/MaskImageOperation.cpp

@@ -194 +194 @@
         return nullptr;
 
-    if (!m_cachedSVGDocumentReference.get()) {
+    if (!m_cachedSVGDocumentReference.get())
         m_cachedSVGDocumentReference = std::make_unique<CachedSVGDocumentReference>(m_url, this, false);
-        // FIXME: For some strange reason we load all mask resources using CachedSVGDocument.
-        //        This requires overriding SVG mime type in Accept header or server may reject the request.
-        m_cachedSVGDocumentReference->setAcceptsAnyImageType();
-    }
     return m_cachedSVGDocumentReference.get();
 }
@@ -224 +220 @@
         }
     }
-
+    
     // If no valid mask was found, this is not a valid SVG document or it specified an invalid fragment identifier.
     // Fallback to the normal way of loading the document in an Image object.
-    // FIXME: This is silly.
     if (!validMaskFound) {
         // Get the resource loader, acquire the resource buffer and load it into an image.