Changeset 186796 in webkit

Timestamp:

Jul 13, 2015 4:53:14 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Uncaught exception in inspector for some ConsoleMessages
​https://bugs.webkit.org/show_bug.cgi?id=146919

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-13
Reviewed by Brian Burg.

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
The parameters list may not exist, so null check it before use.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-07-13  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Uncaught exception in inspector for some ConsoleMessages
+        https://bugs.webkit.org/show_bug.cgi?id=146919
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
+        The parameters list may not exist, so null check it before use.
+
 2015-07-13  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -323 +323 @@
         }
 
-        if (this._message.parameters.length === 1) {
+        if (this._message.parameters && this._message.parameters.length === 1) {
             var parameter = this._createRemoteObjectIfNeeded(this._message.parameters[0]);