Context Navigation

← Previous Changeset
Next Changeset →

Changeset 187587 in webkit

Timestamp:

Jul 30, 2015 9:25:36 AM (9 years ago)

Author:

Chris Dumez

Message:

Mark more classes as fast allocated
https://bugs.webkit.org/show_bug.cgi?id=147440

Reviewed by Sam Weinig.

Mark more classes as fast allocated for performance. We heap-allocate
objects of those types throughout the code base.

Source/JavaScriptCore:

API/JSCallbackObject.h:
API/ObjCCallbackFunction.mm:
bytecode/BytecodeKills.h:
bytecode/BytecodeLivenessAnalysis.h:
bytecode/CallLinkStatus.h:
bytecode/FullBytecodeLiveness.h:
bytecode/SamplingTool.h:
bytecompiler/BytecodeGenerator.h:
dfg/DFGBasicBlock.h:
dfg/DFGBlockMap.h:
dfg/DFGInPlaceAbstractState.h:
dfg/DFGThreadData.h:
heap/HeapVerifier.h:
heap/SlotVisitor.h:
parser/Lexer.h:
runtime/ControlFlowProfiler.h:
runtime/TypeProfiler.h:
runtime/TypeProfilerLog.h:
runtime/Watchdog.h:

Source/WebCore:

editing/Editor.h:
history/CachedFrame.h:
history/CachedPage.h:
html/parser/HTMLResourcePreloader.h:
loader/PolicyChecker.h:
loader/SubresourceLoader.h:
loader/cache/CachedResource.h:
page/animation/AnimationController.h:
page/scrolling/ScrollingConstraints.h:
page/scrolling/ScrollingStateTree.h:
platform/graphics/Font.h:
platform/graphics/GraphicsLayerUpdater.h:
rendering/FilterEffectRenderer.h:
rendering/ImageQualityController.h:
rendering/RenderLayerFilterInfo.h:
rendering/SimpleLineLayoutResolver.h:
rendering/shapes/RasterShape.h:
rendering/shapes/Shape.h:

Source/WebKit2:

NetworkProcess/cache/NetworkCacheStorage.cpp:
NetworkProcess/cache/NetworkCacheStorage.h:
Platform/IPC/MessageRecorder.h:
Platform/mac/LayerHostingContext.h:

Source/WTF:

wtf/Bag.h:
wtf/SegmentedVector.h:
wtf/SentinelLinkedList.h:

Location:

trunk/Source

Files:

: 48 edited

JavaScriptCore/API/JSCallbackObject.h (modified) (1 diff)
JavaScriptCore/API/ObjCCallbackFunction.mm (modified) (2 diffs)
JavaScriptCore/ChangeLog (modified) (1 diff)
JavaScriptCore/bytecode/BytecodeKills.h (modified) (1 diff)
JavaScriptCore/bytecode/BytecodeLivenessAnalysis.h (modified) (1 diff)
JavaScriptCore/bytecode/CallLinkStatus.h (modified) (1 diff)
JavaScriptCore/bytecode/FullBytecodeLiveness.h (modified) (1 diff)
JavaScriptCore/bytecode/SamplingTool.h (modified) (1 diff)
JavaScriptCore/bytecompiler/BytecodeGenerator.h (modified) (1 diff)
JavaScriptCore/dfg/DFGBasicBlock.h (modified) (1 diff)
JavaScriptCore/dfg/DFGBlockMap.h (modified) (1 diff)
JavaScriptCore/dfg/DFGInPlaceAbstractState.h (modified) (1 diff)
JavaScriptCore/dfg/DFGThreadData.h (modified) (1 diff)
JavaScriptCore/heap/HeapVerifier.h (modified) (1 diff)
JavaScriptCore/heap/SlotVisitor.h (modified) (1 diff)
JavaScriptCore/parser/Lexer.h (modified) (1 diff)
JavaScriptCore/runtime/ControlFlowProfiler.h (modified) (1 diff)
JavaScriptCore/runtime/TypeProfiler.h (modified) (1 diff)
JavaScriptCore/runtime/TypeProfilerLog.h (modified) (1 diff)
JavaScriptCore/runtime/Watchdog.h (modified) (1 diff)
WTF/ChangeLog (modified) (1 diff)
WTF/wtf/Bag.h (modified) (1 diff)
WTF/wtf/SegmentedVector.h (modified) (1 diff)
WTF/wtf/SentinelLinkedList.h (modified) (1 diff)
WebCore/ChangeLog (modified) (1 diff)
WebCore/editing/Editor.h (modified) (1 diff)
WebCore/history/CachedFrame.h (modified) (1 diff)
WebCore/history/CachedPage.h (modified) (1 diff)
WebCore/html/parser/HTMLResourcePreloader.h (modified) (1 diff)
WebCore/loader/PolicyChecker.h (modified) (1 diff)
WebCore/loader/SubresourceLoader.h (modified) (1 diff)
WebCore/loader/cache/CachedResource.h (modified) (1 diff)
WebCore/page/animation/AnimationController.h (modified) (1 diff)
WebCore/page/scrolling/ScrollingConstraints.h (modified) (1 diff)
WebCore/page/scrolling/ScrollingStateTree.h (modified) (1 diff)
WebCore/platform/graphics/Font.h (modified) (1 diff)
WebCore/platform/graphics/GraphicsLayerUpdater.h (modified) (1 diff)
WebCore/rendering/FilterEffectRenderer.h (modified) (1 diff)
WebCore/rendering/ImageQualityController.h (modified) (1 diff)
WebCore/rendering/RenderLayerFilterInfo.h (modified) (1 diff)
WebCore/rendering/SimpleLineLayoutResolver.h (modified) (1 diff)
WebCore/rendering/shapes/RasterShape.h (modified) (1 diff)
WebCore/rendering/shapes/Shape.h (modified) (1 diff)
WebKit2/ChangeLog (modified) (1 diff)
WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (modified) (3 diffs)
WebKit2/NetworkProcess/cache/NetworkCacheStorage.h (modified) (1 diff)
WebKit2/Platform/IPC/MessageRecorder.h (modified) (1 diff)
WebKit2/Platform/mac/LayerHostingContext.h (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/Source/JavaScriptCore/API/JSCallbackObject.h

r184828	r187587
80	80	JSClassRef jsClass;
81	81	struct JSPrivatePropertyMap {
	82	WTF_MAKE_FAST_ALLOCATED;
	83	public:
82	84	JSValue getPrivateProperty(const Identifier& propertyName) const
83	85	{

trunk/Source/JavaScriptCore/API/ObjCCallbackFunction.mm

-                      r183005
+                      r187587
 class CallbackArgument {
+    WTF_MAKE_FAST_ALLOCATED;
 public:
     virtual ~CallbackArgument();
 …
 class CallbackResult {
+    WTF_MAKE_FAST_ALLOCATED;
 public:
     virtual ~CallbackResult()

trunk/Source/JavaScriptCore/ChangeLog

-                      r187579
+                      r187587
+-07-30  Chris Dumez  <cdumez@apple.com>
+        Mark more classes as fast allocated
+        https://bugs.webkit.org/show_bug.cgi?id=147440
+        Reviewed by Sam Weinig.
+        Mark more classes as fast allocated for performance. We heap-allocate
+        objects of those types throughout the code base.
+        * API/JSCallbackObject.h:
+        * API/ObjCCallbackFunction.mm:
+        * bytecode/BytecodeKills.h:
+        * bytecode/BytecodeLivenessAnalysis.h:
+        * bytecode/CallLinkStatus.h:
+        * bytecode/FullBytecodeLiveness.h:
+        * bytecode/SamplingTool.h:
+        * bytecompiler/BytecodeGenerator.h:
+        * dfg/DFGBasicBlock.h:
+        * dfg/DFGBlockMap.h:
+        * dfg/DFGInPlaceAbstractState.h:
+        * dfg/DFGThreadData.h:
+        * heap/HeapVerifier.h:
+        * heap/SlotVisitor.h:
+        * parser/Lexer.h:
+        * runtime/ControlFlowProfiler.h:
+        * runtime/TypeProfiler.h:
+        * runtime/TypeProfilerLog.h:
+        * runtime/Watchdog.h:
 -07-29  Filip Pizlo  <fpizlo@apple.com>

trunk/Source/JavaScriptCore/bytecode/BytecodeKills.h

r181993	r187587
35	35
36	36	class BytecodeKills {
	37	WTF_MAKE_FAST_ALLOCATED;
37	38	public:
38	39	BytecodeKills()

trunk/Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.h

r181993	r187587
39	39
40	40	class BytecodeLivenessAnalysis {
	41	WTF_MAKE_FAST_ALLOCATED;
41	42	public:
42	43	BytecodeLivenessAnalysis(CodeBlock*);

trunk/Source/JavaScriptCore/bytecode/CallLinkStatus.h

r185930	r187587
46	46
47	47	class CallLinkStatus {
	48	WTF_MAKE_FAST_ALLOCATED;
48	49	public:
49	50	CallLinkStatus()

trunk/Source/JavaScriptCore/bytecode/FullBytecodeLiveness.h

r183207	r187587
36	36
37	37	class FullBytecodeLiveness {
	38	WTF_MAKE_FAST_ALLOCATED;
38	39	public:
39	40	const FastBitVector& getLiveness(unsigned bytecodeIndex) const

trunk/Source/JavaScriptCore/bytecode/SamplingTool.h

r177130	r187587
228	228
229	229	class SamplingTool {
	230	WTF_MAKE_FAST_ALLOCATED;
230	231	public:
231	232	friend struct CallRecord;

trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h

r187524	r187587
103	103
104	104	class ForInContext {
	105	WTF_MAKE_FAST_ALLOCATED;
105	106	public:
106	107	ForInContext(RegisterID* localRegister)

trunk/Source/JavaScriptCore/dfg/DFGBasicBlock.h

r183497	r187587
238	238
239	239	struct SSAData {
	240	WTF_MAKE_FAST_ALLOCATED;
	241	public:
240	242	AvailabilityMap availabilityAtHead;
241	243	AvailabilityMap availabilityAtTail;

trunk/Source/JavaScriptCore/dfg/DFGBlockMap.h

r184445	r187587
37	37	template<typename T>
38	38	class BlockMap {
	39	WTF_MAKE_FAST_ALLOCATED;
39	40	public:
40	41	BlockMap()

trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h

r171613	r187587
38	38
39	39	class InPlaceAbstractState {
	40	WTF_MAKE_FAST_ALLOCATED;
40	41	public:
41	42	InPlaceAbstractState(Graph&);

trunk/Source/JavaScriptCore/dfg/DFGThreadData.h

r163765	r187587
38	38
39	39	class ThreadData {
	40	WTF_MAKE_FAST_ALLOCATED;
40	41	public:
41	42	ThreadData(Worklist*);

trunk/Source/JavaScriptCore/heap/HeapVerifier.h

r176424	r187587
67	67
68	68	class HeapVerifier {
	69	WTF_MAKE_FAST_ALLOCATED;
69	70	public:
70	71	enum class Phase {

trunk/Source/JavaScriptCore/heap/SlotVisitor.h

r181407	r187587
47	47
48	48	class SlotVisitor {
49		WTF_MAKE_NONCOPYABLE(SlotVisitor);
	49	WTF_MAKE_NONCOPYABLE(SlotVisitor); WTF_MAKE_FAST_ALLOCATED;
50	50	friend class HeapRootVisitor; // Allowed to mark a JSValue* or JSCell** directly.
51	51

trunk/Source/JavaScriptCore/parser/Lexer.h

r186959	r187587
35	35
36	36	class Keywords {
	37	WTF_MAKE_FAST_ALLOCATED;
37	38	public:
38	39	bool isKeyword(const Identifier& ident) const

trunk/Source/JavaScriptCore/runtime/ControlFlowProfiler.h

r179479	r187587
91	91
92	92	class ControlFlowProfiler {
	93	WTF_MAKE_FAST_ALLOCATED;
93	94	public:
94	95	ControlFlowProfiler();

trunk/Source/JavaScriptCore/runtime/TypeProfiler.h

r176836	r187587
95	95
96	96	class TypeProfiler {
	97	WTF_MAKE_FAST_ALLOCATED;
97	98	public:
98	99	TypeProfiler();

trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.h

r184291	r187587
40	40
41	41	class TypeProfilerLog {
42
	42	WTF_MAKE_FAST_ALLOCATED;
43	43	public:
44	44	struct LogEntry {

trunk/Source/JavaScriptCore/runtime/Watchdog.h

r176973	r187587
37	37
38	38	class Watchdog {
	39	WTF_MAKE_FAST_ALLOCATED;
39	40	public:
40	41	class Scope;

trunk/Source/WTF/ChangeLog

-                      r187555
+                      r187587
+-07-30  Chris Dumez  <cdumez@apple.com>
+        Mark more classes as fast allocated
+        https://bugs.webkit.org/show_bug.cgi?id=147440
+        Reviewed by Sam Weinig.
+        Mark more classes as fast allocated for performance. We heap-allocate
+        objects of those types throughout the code base.
+        * wtf/Bag.h:
+        * wtf/SegmentedVector.h:
+        * wtf/SentinelLinkedList.h:
 -07-29  Basile Clement  <basile_clement@apple.com>

trunk/Source/WTF/wtf/Bag.h

r173993	r187587
31	31	template<typename T>
32	32	class Bag {
	33	WTF_MAKE_FAST_ALLOCATED;
33	34	private:
34	35	class Node {

trunk/Source/WTF/wtf/SegmentedVector.h

r186207	r187587
92	92	friend class SegmentedVectorIterator<T, SegmentSize>;
93	93	WTF_MAKE_NONCOPYABLE(SegmentedVector);
	94	WTF_MAKE_FAST_ALLOCATED;
94	95
95	96	public:

trunk/Source/WTF/wtf/SentinelLinkedList.h

r157653	r187587
44	44	template<typename T>
45	45	class BasicRawSentinelNode {
	46	WTF_MAKE_FAST_ALLOCATED;
46	47	public:
47	48	BasicRawSentinelNode(SentinelTag)

trunk/Source/WebCore/ChangeLog

-                      r187586
+                      r187587
+-07-30  Chris Dumez  <cdumez@apple.com>
+        Mark more classes as fast allocated
+        https://bugs.webkit.org/show_bug.cgi?id=147440
+        Reviewed by Sam Weinig.
+        Mark more classes as fast allocated for performance. We heap-allocate
+        objects of those types throughout the code base.
+        * editing/Editor.h:
+        * history/CachedFrame.h:
+        * history/CachedPage.h:
+        * html/parser/HTMLResourcePreloader.h:
+        * loader/PolicyChecker.h:
+        * loader/SubresourceLoader.h:
+        * loader/cache/CachedResource.h:
+        * page/animation/AnimationController.h:
+        * page/scrolling/ScrollingConstraints.h:
+        * page/scrolling/ScrollingStateTree.h:
+        * platform/graphics/Font.h:
+        * platform/graphics/GraphicsLayerUpdater.h:
+        * rendering/FilterEffectRenderer.h:
+        * rendering/ImageQualityController.h:
+        * rendering/RenderLayerFilterInfo.h:
+        * rendering/SimpleLineLayoutResolver.h:
+        * rendering/shapes/RasterShape.h:
+        * rendering/shapes/Shape.h:
 -07-30  Michael Catanzaro  <mcatanzaro@igalia.com>

trunk/Source/WebCore/editing/Editor.h

r187521	r187587
98	98
99	99	class Editor {
	100	WTF_MAKE_FAST_ALLOCATED;
100	101	public:
101	102	explicit Editor(Frame&);

trunk/Source/WebCore/history/CachedFrame.h

r172814	r187587
67	67
68	68	class CachedFrame : private CachedFrameBase {
	69	WTF_MAKE_FAST_ALLOCATED;
69	70	public:
70	71	explicit CachedFrame(Frame&);

trunk/Source/WebCore/history/CachedPage.h

r184304	r187587
36	36
37	37	class CachedPage {
	38	WTF_MAKE_FAST_ALLOCATED;
38	39	public:
39	40	explicit CachedPage(Page&);

trunk/Source/WebCore/html/parser/HTMLResourcePreloader.h

r183901	r187587
33	33
34	34	class PreloadRequest {
	35	WTF_MAKE_FAST_ALLOCATED;
35	36	public:
36	37	PreloadRequest(const String& initiator, const String& resourceURL, const URL& baseURL, CachedResource::Type resourceType, const String& mediaAttribute)

trunk/Source/WebCore/loader/PolicyChecker.h

r182356	r187587
52	52	class PolicyChecker {
53	53	WTF_MAKE_NONCOPYABLE(PolicyChecker);
	54	WTF_MAKE_FAST_ALLOCATED;
54	55	public:
55	56	explicit PolicyChecker(Frame&);

trunk/Source/WebCore/loader/SubresourceLoader.h

r187002	r187587
107	107
108	108	class RequestCountTracker {
	109	WTF_MAKE_FAST_ALLOCATED;
109	110	public:
110	111	RequestCountTracker(CachedResourceLoader&, CachedResource*);

trunk/Source/WebCore/loader/cache/CachedResource.h

r187466	r187587
349	349
350	350	class CachedResource::Callback {
	351	WTF_MAKE_FAST_ALLOCATED;
351	352	public:
352	353	Callback(CachedResource&, CachedResourceClient&);

trunk/Source/WebCore/page/animation/AnimationController.h

r183454	r187587
45	45
46	46	class AnimationController {
	47	WTF_MAKE_FAST_ALLOCATED;
47	48	public:
48	49	explicit AnimationController(Frame&);

trunk/Source/WebCore/page/scrolling/ScrollingConstraints.h

r180441	r187587
34	34	// depends on the viewport rect (positions fixed and sticky), when scrolling and zooming.
35	35	class ViewportConstraints {
	36	WTF_MAKE_FAST_ALLOCATED;
36	37	public:
37	38	enum ConstraintType {

trunk/Source/WebCore/page/scrolling/ScrollingStateTree.h

r177835	r187587
42	42
43	43	class ScrollingStateTree {
	44	WTF_MAKE_FAST_ALLOCATED;
44	45	friend class ScrollingStateNode;
45	46	public:

trunk/Source/WebCore/platform/graphics/Font.h

r185842	r187587
268	268
269	269	struct DerivedFontData {
	270	WTF_MAKE_FAST_ALLOCATED;
	271	public:
270	272	explicit DerivedFontData(bool custom)
271	273	: forCustomFont(custom)

trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h

r185372	r187587
48	48	#endif
49	49	{
	50	WTF_MAKE_FAST_ALLOCATED;
50	51	public:
51	52	GraphicsLayerUpdater(GraphicsLayerUpdaterClient&, PlatformDisplayID);

trunk/Source/WebCore/rendering/FilterEffectRenderer.h

r185517	r187587
56	56
57	57	class FilterEffectRendererHelper {
	58	WTF_MAKE_FAST_ALLOCATED;
58	59	public:
59	60	FilterEffectRendererHelper(bool haveFilterEffect)

trunk/Source/WebCore/rendering/ImageQualityController.h

r176459	r187587
40	40
41	41	class ImageQualityController {
42		WTF_MAKE_NONCOPYABLE(ImageQualityController)
	42	WTF_MAKE_NONCOPYABLE(ImageQualityController); WTF_MAKE_FAST_ALLOCATED;
43	43	public:
44	44	explicit ImageQualityController(const RenderView&);

trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h

r186392	r187587
42	42
43	43	class RenderLayer::FilterInfo final : private CachedSVGDocumentClient {
	44	WTF_MAKE_FAST_ALLOCATED;
44	45	public:
45	46	static FilterInfo& get(RenderLayer&);

trunk/Source/WebCore/rendering/SimpleLineLayoutResolver.h

r182620	r187587
51	51
52	52	class RunResolver {
	53	WTF_MAKE_FAST_ALLOCATED;
53	54	public:
54	55	class Iterator;

trunk/Source/WebCore/rendering/shapes/RasterShape.h

r175084	r187587
40	40
41	41	class RasterShapeIntervals {
	42	WTF_MAKE_FAST_ALLOCATED;
42	43	public:
43	44	RasterShapeIntervals(unsigned size, int offset = 0)

trunk/Source/WebCore/rendering/shapes/Shape.h

r174805	r187587
67	67
68	68	class Shape {
	69	WTF_MAKE_FAST_ALLOCATED;
69	70	public:
70	71	struct DisplayPaths {

trunk/Source/WebKit2/ChangeLog

-                      r187575
+                      r187587
+-07-30  Chris Dumez  <cdumez@apple.com>
+        Mark more classes as fast allocated
+        https://bugs.webkit.org/show_bug.cgi?id=147440
+        Reviewed by Sam Weinig.
+        Mark more classes as fast allocated for performance. We heap-allocate
+        objects of those types throughout the code base.
+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
+        * NetworkProcess/cache/NetworkCacheStorage.h:
+        * Platform/IPC/MessageRecorder.h:
+        * Platform/mac/LayerHostingContext.h:
 -07-29  Andy VanWagoner  <thetalecrafter@gmail.com>

trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp

-                      r186714
+                      r187587
 struct Storage::ReadOperation {
+    WTF_MAKE_FAST_ALLOCATED;
+public:
     ReadOperation(const Key& key, const RetrieveCompletionHandler& completionHandler)
         : key(key)
 …
 struct Storage::WriteOperation {
+    WTF_MAKE_FAST_ALLOCATED;
+public:
     WriteOperation(const Record& record, const MappedBodyHandler& mappedBodyHandler)
         : record(record)
 …
 struct Storage::TraverseOperation {
+    WTF_MAKE_FAST_ALLOCATED;
+public:
     TraverseOperation(TraverseFlags flags, const TraverseHandler& handler)
         : flags(flags)

trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h

r186224	r187587
51	51
52	52	struct Record {
	53	WTF_MAKE_FAST_ALLOCATED;
	54	public:
53	55	Key key;
54	56	std::chrono::system_clock::time_point timeStamp;

trunk/Source/WebKit2/Platform/IPC/MessageRecorder.h

r179346	r187587
69	69
70	70	class MessageProcessingToken {
71		WTF_MAKE_NONCOPYABLE(MessageProcessingToken);
	71	WTF_MAKE_NONCOPYABLE(MessageProcessingToken); WTF_MAKE_FAST_ALLOCATED;
72	72	public:
73	73	explicit MessageProcessingToken(WebKitMessageRecord);

trunk/Source/WebKit2/Platform/mac/LayerHostingContext.h

r186878	r187587
42	42
43	43	class LayerHostingContext {
44		WTF_MAKE_NONCOPYABLE(LayerHostingContext);
	44	WTF_MAKE_NONCOPYABLE(LayerHostingContext); WTF_MAKE_FAST_ALLOCATED;
45	45	public:
46	46	static std::unique_ptr<LayerHostingContext> createForPort(const WebCore::MachSendRight& serverPort);

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 187587 in webkit

Legend:

Download in other formats: