Changeset 189093 in webkit


Ignore:
Timestamp:
Aug 28, 2015 2:48:41 AM (9 years ago)
Author:
calvaris@igalia.com
Message:

Layout Test streams/reference-implementation/readable-stream.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=148320

Reviewed by Alexey Proskuryakov.

  • streams/reference-implementation/readable-stream.html: Set the timeouts at the last moment so that it is less

likely to hit them earlier that we should.

Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r189092 r189093  
     12015-08-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
     2
     3        Layout Test streams/reference-implementation/readable-stream.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=148320
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        * streams/reference-implementation/readable-stream.html: Set the timeouts at the last moment so that it is less
     9        likely to hit them earlier that we should.
     10
    1112015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
    212
  • trunk/LayoutTests/streams/reference-implementation/readable-stream.html

    r188684 r189093  
    269269    startPromise.then(test6.step_func(function() {
    270270        assert_equals(pullCount, 1, 'pull should be called once start finishes');
    271     }));
    272 
    273     setTimeout(test6.step_func(function() {
    274         assert_equals(pullCount, 1, 'pull should be called exactly once');
    275         test6.done();
    276     }), 1000);
     271
     272        setTimeout(test6.step_func(function() {
     273            assert_equals(pullCount, 1, 'pull should be called exactly once');
     274            test6.done();
     275        }), 1000);
     276    }));
     277
    277278});
    278279
     
    328329        assert_object_equals(r, { value: 'a', done: false }, 'first read() should return first chunk');
    329330        assert_equals(pullCount, 1, 'pull should not have been called again');
     331
     332        setTimeout(test8.step_func(function() {
     333            assert_equals(pullCount, 1, 'pull should be called exactly once');
     334            test8.done();
     335        }), 1000);
    330336    }));
    331337
    332338    assert_equals(pullCount, 0, 'calling read() should not cause pull to be called yet');
    333 
    334     setTimeout(test8.step_func(function() {
    335         assert_equals(pullCount, 1, 'pull should be called exactly once');
    336         test8.done();
    337     }), 1000);
    338339});
    339340
     
    530531        pull: function(c) {
    531532            c.enqueue(++timesCalled);
     533
     534            if (timesCalled == 4) {
     535                setTimeout(test14.step_func(function() {
     536                    // after start: size = 0, pull()
     537                    // after enqueue(1): size = 1, pull()
     538                    // after enqueue(2): size = 2, pull()
     539                    // after enqueue(3): size = 3, pull()
     540                    // after enqueue(4): size = 4, do not pull
     541                    assert_equals(timesCalled, 4, 'pull() should have been called four times');
     542                    test14.done();
     543                }), 1000);
     544            }
    532545        }
    533546    },
     
    538551        highWaterMark: 4
    539552    });
    540 
    541     setTimeout(test14.step_func(function() {
    542         // after start: size = 0, pull()
    543         // after enqueue(1): size = 1, pull()
    544         // after enqueue(2): size = 2, pull()
    545         // after enqueue(3): size = 3, pull()
    546         // after enqueue(4): size = 4, do not pull
    547         assert_equals(timesCalled, 4, 'pull() should have been called four times');
    548         test14.done();
    549     }), 1000);
    550553});
    551554
Note: See TracChangeset for help on using the changeset viewer.