Changeset 189566 in webkit


Ignore:
Timestamp:
Sep 10, 2015 2:10:11 AM (9 years ago)
Author:
ChangSeok Oh
Message:

[GTK] Volume bar is broken
​https://bugs.webkit.org/show_bug.cgi?id=145639

Reviewed by Philippe Normand.

Source/WebCore:

The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.

Tests: media/click-volume-bar-not-pausing.html

media/volume-bar-empty-when-muted.html

  • platform/ThemeTypes.h:

LayoutTests:

Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r189564 r189566  
     12015-09-10  ChangSeok Oh  <changseok.oh@collabora.com>
     2
     3        [GTK] Volume bar is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=145639
     5
     6        Reviewed by Philippe Normand.
     7
     8        Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html
     9
     10        * platform/gtk/TestExpectations:
     11
    1122015-09-09  Dewei Zhu  <dewei_zhu@apple.com>
    213

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r189487 r189566  
    13511351
    13521352webkit.org/b/142820 fast/images/animated-gif-body-outside-viewport.html [ Timeout Pass ]
    1353 webkit.org/b/142491 media/click-volume-bar-not-pausing.html [ Timeout ]
    13541353webkit.org/b/143473 editing/pasteboard/drag-and-drop-attachment-contenteditable.html [ Timeout ]
    13551354
    … …  
    22342233
    22352234webkit.org/b/132235 fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html [ ImageOnlyFailure ]
    2236 
    2237 webkit.org/b/132253 media/volume-bar-empty-when-muted.html [ Failure ]
    22382235
    22392236webkit.org/b/132910 editing/pasteboard/drag-drop-paragraph-crasher.html [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r189565 r189566  
     12015-09-10  ChangSeok Oh  <changseok.oh@collabora.com>
     2
     3        [GTK] Volume bar is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=145639
     5
     6        Reviewed by Philippe Normand.
     7
     8        The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
     9        after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.
     10
     11        Tests: media/click-volume-bar-not-pausing.html
     12               media/volume-bar-empty-when-muted.html
     13
     14        * platform/ThemeTypes.h:
     15
    1162015-09-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
    217

  • trunk/Source/WebCore/platform/ThemeTypes.h

    r185481 r189566  
    3939    MediaPlayButtonPart, MediaReturnToRealtimeButtonPart, MediaRewindButtonPart, MediaSeekBackButtonPart,
    4040    MediaSeekForwardButtonPart, MediaSliderPart, MediaSliderThumbPart, MediaTimeRemainingPart,
    41     MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderContainerPart, MediaVolumeSliderMuteButtonPart,
    42     MediaVolumeSliderPart, MediaVolumeSliderThumbPart,
     41    MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderPart, MediaVolumeSliderContainerPart,
     42    MediaVolumeSliderMuteButtonPart, MediaVolumeSliderThumbPart,
    4343    MenulistPart, MenulistButtonPart, MenulistTextPart, MenulistTextFieldPart, MeterPart, ProgressBarPart, ProgressBarValuePart,
    4444    SliderHorizontalPart, SliderVerticalPart, SliderThumbHorizontalPart,
Note: See TracChangeset for help on using the changeset viewer.