Changeset 190053 in webkit

Timestamp:

Sep 21, 2015 1:37:25 AM (9 years ago)

Author:

ChangSeok Oh

Message:

[GTK] timeline is not updated after few seconds when mouse hovers on controls
​https://bugs.webkit.org/show_bug.cgi?id=149111

Reviewed by Philippe Normand.

Source/WebCore:

Timeline is not updated if controlsAreHidden is true. The problem here is that
the function does not mean actually 'hidden' since it only checkes 'show' and 'hidden'
class existences. The panel's visibility are not only controlled by the two classes,
but also by video::-webkit-media-controls-panel:hover. The panel could be visible
by setting the pseudo hover class. So we need to check if panel is hovered as well in controlsAreHidden().

Test: media/media-controls-timeline-updates-when-hovered.html

• Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.controlsAreHidden):

LayoutTests:

• media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
• media/media-controls-timeline-updates-when-hovered.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/media-controls-timeline-updates-when-hovered-expected.txt (added)
• LayoutTests/media/media-controls-timeline-updates-when-hovered.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediacontrols/mediaControlsBase.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-09-21  ChangSeok Oh  <changseok.oh@collabora.com>
+
+        [GTK] timeline is not updated after few seconds when mouse hovers on controls
+        https://bugs.webkit.org/show_bug.cgi?id=149111
+
+        Reviewed by Philippe Normand.
+
+        * media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
+        * media/media-controls-timeline-updates-when-hovered.html: Added.
+
 2015-09-20  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-09-21  ChangSeok Oh  <changseok.oh@collabora.com>
+
+        [GTK] timeline is not updated after few seconds when mouse hovers on controls
+        https://bugs.webkit.org/show_bug.cgi?id=149111
+
+        Reviewed by Philippe Normand.
+
+        Timeline is not updated if controlsAreHidden is true. The problem here is that
+        the function does not mean actually 'hidden' since it only checkes 'show' and 'hidden'
+        class existences. The panel's visibility are not only controlled by the two classes,
+        but also by video::-webkit-media-controls-panel:hover. The panel could be visible
+        by setting the pseudo hover class. So we need to check if panel is hovered as well in controlsAreHidden().
+
+        Test: media/media-controls-timeline-updates-when-hovered.html
+
+        * Modules/mediacontrols/mediaControlsBase.js:
+        (Controller.prototype.controlsAreHidden):
+
 2015-09-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js

@@ -1024 +1024 @@
     controlsAreHidden: function()
     {
-        return !this.controls.panel.classList.contains(this.ClassNames.show) || this.controls.panel.classList.contains(this.ClassNames.hidden);
+        var panel = this.controls.panel;
+        return (!panel.classList.contains(this.ClassNames.show) || panel.classList.contains(this.ClassNames.hidden))
+            && (panel.parentElement.querySelector(':hover') !== panel);
     },