Changeset 190054 in webkit

Timestamp:

Sep 21, 2015, 1:53:01 AM (10 years ago)

Author:

ChangSeok Oh

Message:

[GTK] media controls does not show up when playing video finishes.
​https://bugs.webkit.org/show_bug.cgi?id=149112

Reviewed by Philippe Normand.

Source/WebCore:

GTK port does not show controls after playing video. This behavior is different
from what Mac port does. They do show controls when playing video finishes.
At least, we should update the timeline before showing it up not to show incorrect numbers
when reappearing.

Test: media/media-controls-timeline-updates-after-playing.html

• Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.setPlaying):
(Controller.prototype.showControls):

LayoutTests:

• media/media-controls-timeline-updates-after-playing-expected.txt: Added.
• media/media-controls-timeline-updates-after-playing.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/media-controls-timeline-updates-after-playing-expected.txt (added)
• LayoutTests/media/media-controls-timeline-updates-after-playing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediacontrols/mediaControlsBase.js (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-09-21  ChangSeok Oh  <changseok.oh@collabora.com>
+
+        [GTK] media controls does not show up when playing video finishes.
+        https://bugs.webkit.org/show_bug.cgi?id=149112
+
+        Reviewed by Philippe Normand.
+
+        * media/media-controls-timeline-updates-after-playing-expected.txt: Added.
+        * media/media-controls-timeline-updates-after-playing.html: Added.
+
 2015-09-21  ChangSeok Oh  <changseok.oh@collabora.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-09-21  ChangSeok Oh  <changseok.oh@collabora.com>
+
+        [GTK] media controls does not show up when playing video finishes.
+        https://bugs.webkit.org/show_bug.cgi?id=149112
+
+        Reviewed by Philippe Normand.
+
+        GTK port does not show controls after playing video. This behavior is different
+        from what Mac port does. They do show controls when playing video finishes.
+        At least, we should update the timeline before showing it up not to show incorrect numbers
+        when reappearing.
+
+        Test: media/media-controls-timeline-updates-after-playing.html
+
+        * Modules/mediacontrols/mediaControlsBase.js:
+        (Controller.prototype.setPlaying):
+        (Controller.prototype.showControls):
+
 2015-09-21  ChangSeok Oh  <changseok.oh@collabora.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js

@@ -999 +999 @@
             this.controls.playButton.classList.add(this.ClassNames.paused);
             this.controls.playButton.setAttribute('aria-label', this.UIString('Play'));
+            this.showControls();
         } else {
             this.controls.panel.classList.remove(this.ClassNames.paused);
@@ -1014 +1015 @@
         this.controls.panel.classList.remove(this.ClassNames.hidden);
 
+        this.updateTime();
         this.setNeedsTimelineMetricsUpdate();
     },