Changeset 190133 in webkit

Timestamp:

Sep 22, 2015 2:11:35 PM (9 years ago)

Author:

aestes@apple.com

Message:

ContentFiltering.AllowDownloadAfterAddData is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>

Reviewed by Alexey Proskuryakov.

The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.

• TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:

(downloadTest):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-09-22  Andy Estes  <aestes@apple.com>
+
+        ContentFiltering.AllowDownloadAfterAddData is very flaky
+        https://bugs.webkit.org/show_bug.cgi?id=148885
+        <rdar://problem/22729563>
+
+        Reviewed by Alexey Proskuryakov.
+
+        The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
+        but there is no guarantee of this. For tests that should allow a download, spin the runloop until
+        -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
+
+        * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
+        (downloadTest):
+
 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm

@@ -186 +186 @@
         isDone = false;
         downloadDidStart = false;
-        TestWebKitAPI::Util::run(&isDone);
-
         const bool downloadShouldStart = decision == Decision::Allow || decisionPoint > DecisionPoint::AfterResponse;
+        if (downloadShouldStart)
+            TestWebKitAPI::Util::run(&downloadDidStart);
+        else
+            TestWebKitAPI::Util::run(&isDone);
+
         EXPECT_EQ(downloadShouldStart, downloadDidStart);