Changeset 190160 in webkit


Ignore:
Timestamp:
Sep 23, 2015 4:07:15 AM (9 years ago)
Author:
ChangSeok Oh
Message:

[GTK] playbutton in media controls is not changed when it is clicked.
​https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

  • css/mediaControlsGtk.css:

(video::-webkit-media-controls-play-button.paused):

LayoutTests:

  • media/media-controls-play-button-updates-expected.png: Added.
  • media/media-controls-play-button-updates-expected.txt: Added.
  • media/media-controls-play-button-updates.html: Added.
  • platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
  • platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r190159 r190160  
     12015-09-23  ChangSeok Oh  <changseok.oh@collabora.com>
     2
     3        [GTK] playbutton in media controls is not changed when it is clicked.
     4        https://bugs.webkit.org/show_bug.cgi?id=149113
     5
     6        Reviewed by Philippe Normand.
     7
     8        * media/media-controls-play-button-updates-expected.png: Added.
     9        * media/media-controls-play-button-updates-expected.txt: Added.
     10        * media/media-controls-play-button-updates.html: Added.
     11        * platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
     12        * platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
     13
    1142015-09-23  Xabier Rodriguez Calvar  <calvaris@igalia.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r190155 r190160  
     12015-09-23  ChangSeok Oh  <changseok.oh@collabora.com>
     2
     3        [GTK] playbutton in media controls is not changed when it is clicked.
     4        https://bugs.webkit.org/show_bug.cgi?id=149113
     5
     6        Reviewed by Philippe Normand.
     7
     8        When the play button in media controls is clicked, a 'paused' class is added or removed
     9        for the element to update its appearance. Although Document::recalcStyle is triggered
     10        by that class attribute change, the play button is not changed since there is
     11        no difference in styles whether having the 'paused' class or not. Gtk port
     12        does not define the -webkit-media-controls-play-button.paused. To fix this,
     13        -webkit-media-controls-play-button.paused is newly defined with a dummy style,
     14        "position: relative;", which should not change the play button appearance,
     15        but be clearly different in style.
     16
     17        Test: media/media-controls-play-button-updates.html
     18
     19        * css/mediaControlsGtk.css:
     20        (video::-webkit-media-controls-play-button.paused):
     21
    1222015-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
    223

  • trunk/Source/WebCore/css/mediaControlsGtk.css

    r188653 r190160  
    146146}
    147147
     148/* paused classes for audio/video controls should be defined to make a difference in style from not having this class. Overwise a repaint would not happen. */
     149audio::-webkit-media-controls-play-button.paused,
     150video::-webkit-media-controls-play-button.paused {
     151    position: relative;
     152}
     153
    148154audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display,
    149155audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display {
Note: See TracChangeset for help on using the changeset viewer.