Changeset 190246 in webkit

Timestamp:

Sep 25, 2015 10:51:28 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Reloading the page causes the inspector tab to switch back to "Resources" tab
​https://bugs.webkit.org/show_bug.cgi?id=148732

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-25
Reviewed by Darin Adler.

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
Suppress selection of sibiling tree elements when removing extra folders.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ResourceSidebarPanel.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-09-25  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Reloading the page causes the inspector tab to switch back to "Resources" tab
+        https://bugs.webkit.org/show_bug.cgi?id=148732
+
+        Reviewed by Darin Adler.
+
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
+        Suppress selection of sibiling tree elements when removing extra folders.
+
 2015-09-24  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

@@ -312 +312 @@
     _scriptsCleared(event)
     {
+        const suppressOnDeselect = true;
+        const suppressSelectSibling = true;
+        
         if (this._extensionScriptsFolderTreeElement) {
             if (this._extensionScriptsFolderTreeElement.parent)
-                this._extensionScriptsFolderTreeElement.parent.removeChild(this._extensionScriptsFolderTreeElement);
+                this._extensionScriptsFolderTreeElement.parent.removeChild(this._extensionScriptsFolderTreeElement, suppressOnDeselect, suppressSelectSibling);
             this._extensionScriptsFolderTreeElement = null;
         }
@@ -320 +323 @@
         if (this._extraScriptsFolderTreeElement) {
             if (this._extraScriptsFolderTreeElement.parent)
-                this._extraScriptsFolderTreeElement.parent.removeChild(this._extraScriptsFolderTreeElement);
+                this._extraScriptsFolderTreeElement.parent.removeChild(this._extraScriptsFolderTreeElement, suppressOnDeselect, suppressSelectSibling);
             this._extraScriptsFolderTreeElement = null;
         }
@@ -326 +329 @@
         if (this._anonymousScriptsFolderTreeElement) {
             if (this._anonymousScriptsFolderTreeElement.parent)
-                this._anonymousScriptsFolderTreeElement.parent.removeChild(this._anonymousScriptsFolderTreeElement);
+                this._anonymousScriptsFolderTreeElement.parent.removeChild(this._anonymousScriptsFolderTreeElement, suppressOnDeselect, suppressSelectSibling);
             this._anonymousScriptsFolderTreeElement = null;
         }