Changeset 19038 in webkit

Timestamp:

Jan 22, 2007 8:00:54 PM (17 years ago)

Author:

bdash

Message:

2007-01-22 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11692
Bug 11692: REGRESSION(r17352): Disappearing page title

• dom/Document.cpp: (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript, ignore any changes to it due to encountering <title> tags.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-01-22  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11692
+        Bug 11692: REGRESSION(r17352): Disappearing page title
+
+        * dom/Document.cpp:
+        (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript,
+        ignore any changes to it due to encountering <title> tags.
+
 2007-01-22  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/dom/Document.cpp

@@ -817 +817 @@
         m_titleElement = 0;
     } else if (titleElement != m_titleElement) {
-        if (m_titleElement)
+        if (m_titleElement || m_titleSetExplicitly)
             // Only allow the first title element to change the title -- others have no effect.
             return;